[U-Boot] [RFC, PATCH v4 04/16] env: flash: add U-Boot environment context support

Wolfgang Denk wd at denx.de
Fri Jul 19 08:14:06 UTC 2019


Dear AKASHI Takahiro,

In message <20190717082525.891-5-takahiro.akashi at linaro.org> you wrote:
> This patch shows how environment storage drivers should be modified
> at the minimum to support contexts.

This commit message is misleading.  No part of this patch is related
to contexts.  What it acually does is adding support for variable
sized environment blocks.  The commit message should be fixed.


Also this commit makes me wonder if you have tested your patches for
bisectability.  it seems changes that belong to together (like
making the envionment size variable) are split across patches.  This
needs probably refacturing / resorting.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What can it profit a man to gain the whole world and to come  to  his
property with a gastric ulcer, a blown prostate, and bifocals?
                                     -- John Steinbeck, _Cannery Row_


More information about the U-Boot mailing list