[U-Boot] [RFC,PATCH v4 14/16] env: fat: support UEFI context

[Wolfgang Denk]

Dear Takahiro,

In message <20190717082525.891-15-takahiro.akashi at linaro.org> you wrote:
> With this patch, UEFI will be allowed to save/load variables to
> fat filesystem. The following configurations should be defined.
...
> +#if defined(CONFIG_ENV_EFI_FAT_INTERFACE) && \
> +	defined(CONFIG_ENV_FAT_DEVICE_AND_PART) && \
> +	defined(CONFIG_ENV_EFI_FAT_FILE)
> +	[ENVCTX_UEFI] = {
> +		CONFIG_ENV_EFI_FAT_INTERFACE,
> +		CONFIG_ENV_EFI_FAT_DEVICE_AND_PART,
> +		CONFIG_ENV_EFI_FAT_FILE,
> +	},
> +#endif

This looks bad to me, as you will not get any error when one of the
defintions is missing.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Systems programmers are the high priests of a low cult.
                                                       -- R.S. Barton