[U-Boot] [PATCH] Makefile: fix implementation of BINMAN_DEBUG

Stephen Warren swarren at wwwdotorg.org
Fri Jul 19 17:21:17 UTC 2019


From: Stephen Warren <swarren at nvidia.com>

binman only accepts the -D argument early on the command-line, yet the
Makefile currently passes it near the end. This causes the build to fail
if this feature is used. Re-order the command-line to fix this.

Signed-off-by: Stephen Warren <swarren at nvidia.com>
---
Note: This appears to be a change introduced in u-boot-dm.git master;
the binman currently in u-boot.git master doesn't seem to need this.
---
 Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 704579bec193..5906871ef27f 100644
--- a/Makefile
+++ b/Makefile
@@ -1196,9 +1196,10 @@ u-boot.ldr:	u-boot
 # ---------------------------------------------------------------------------
 # Use 'make BINMAN_DEBUG=1' to enable debugging
 quiet_cmd_binman = BINMAN  $@
-cmd_binman = $(srctree)/tools/binman/binman build -u -d u-boot.dtb -O . -m \
+cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
+                build -u -d u-boot.dtb -O . -m \
 		-I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \
-		$(if $(BINMAN_DEBUG),-D) $(BINMAN_$(@F))
+		$(BINMAN_$(@F))
 
 OBJCOPYFLAGS_u-boot.ldr.hex := -I binary -O ihex
 
-- 
2.22.0



More information about the U-Boot mailing list