[U-Boot] [PATCH 1/2] rockchip: Fix TPL build without CONFIG_TPL_SERIAL_SUPPORT

Kever Yang kever.yang at rock-chips.com
Sun Jul 21 03:30:39 UTC 2019


Hi Chris,


On 2019/7/19 下午9:23, Chris Webb wrote:
> If CONFIG_DEBUG_UART is set but CONFIG_TPL_SERIAL_SUPPORT is not, the
> serial output should be available in SPL and full U-Boot, but not built
> in TPL. However, the rockchip tpl.c instead fails to compile with
> undefined references to the debug UART.
>
> Instead, initialise the debug UART and print the TPL banner only if both
> CONFIG_DEBUG_UART and CONFIG_TPL_SERIAL_SUPPORT are set.
>
> Signed-off-by: <chris at arachsys.com>

Reviewed-by: Kever Yang <Kever.yang at rock-chips.com>

Thanks,
  - Kever
> ---
>   arch/arm/mach-rockchip/tpl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/tpl.c b/arch/arm/mach-rockchip/tpl.c
> index 0ff2a197ed..5df88bddeb 100644
> --- a/arch/arm/mach-rockchip/tpl.c
> +++ b/arch/arm/mach-rockchip/tpl.c
> @@ -44,7 +44,7 @@ void board_init_f(ulong dummy)
>   	struct udevice *dev;
>   	int ret;
>   
> -#ifdef CONFIG_DEBUG_UART
> +#if defined(CONFIG_DEBUG_UART) && defined(CONFIG_TPL_SERIAL_SUPPORT)
>   	/*
>   	 * Debug UART can be used from here if required:
>   	 *
>




More information about the U-Boot mailing list