[U-Boot] [PATCH] fpga: arria10: Fix error in fpga pin configuration

Marek Vasut marex at denx.de
Sun Jul 21 10:46:26 UTC 2019


On 7/16/19 6:28 PM, Dalon Westergreen wrote:
> From: Dalon Westergreen <dalon.westergreen at intel.com>
> 
> Pin configuration of the FPGA devicetree block should be done
> after core configuration in the arria10 fpga driver.  This fix
> corrects the check of status, and ensures that the fpga pin mux
> is configured on correct configuration of the core fpga image.
> 
> Signed-off-by: Dalon Westergreen <dalon.westergreen at intel.com>
> ---
>  drivers/fpga/socfpga_arria10.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/fpga/socfpga_arria10.c b/drivers/fpga/socfpga_arria10.c
> index 285280e507..5fb9d6a191 100644
> --- a/drivers/fpga/socfpga_arria10.c
> +++ b/drivers/fpga/socfpga_arria10.c
> @@ -936,10 +936,11 @@ int socfpga_load(Altera_desc *desc, const void *rbf_data, size_t rbf_size)
>  	fpgamgr_program_write(rbf_data, rbf_size);
>  
>  	status = fpgamgr_program_finish();
> -	if (status) {
> -		config_pins(gd->fdt_blob, "fpga");
> -		puts("FPGA: Enter user mode.\n");
> -	}
> +	if (status)
> +		return status;
> +
> +	config_pins(gd->fdt_blob, "fpga");
> +	puts("FPGA: Enter user mode.\n");
>  
>  	return status;
>  }
> 

Applied, thanks.


More information about the U-Boot mailing list