[U-Boot] [PATCH V3 0/5] add i.MX8 container loading support

[Schrempf Frieder]

On 22.07.19 04:12, Peng Fan wrote:
> V3:
>   Drops patch 1/5 from V2, add 8QM support, nothing else changed.
>   Stefano,
>   This patchset was pending in patchwork for more that one month,
>   please consider to apply.

I'm not the one to judge here and I don't know the rules for U-Boot, but 
only because they have been pending for a long time, doesn't make the 
patches more suitable for upstream. Even more so, if no one has reviewed 
them yet.

> 
> V2:
>   Drop cleanup Makefile since V1, that patch is not correct.
>   Rebased on master
> 
> The V2 version:
> https://patchwork.ozlabs.org/cover/1118413/
> 
> The V1 version:
> https://patchwork.ozlabs.org/cover/1096334/
> 
> This patchset is to support i.MX8 container loading from SPL,
> i.MX8 AHAB secure boot not support FIT image, so we need to
> use container image.
> 
> Currently still use a fixed offset for the 2nd container(u-boot.cnt),
> future patches will drop this fixed offset and use dynamaic offset
> according to the size of 1st container for spl.
> Only MMC is supported now, future patches will also support SPI/NOR/NAND
> following similar style as mmc part, if the mmc part is ok.
> 
> Based on the comments in https://patchwork.ozlabs.org/patch/1096336/
> So I think we have agreed the approach, the only comments that
> not addressed from Lukasz is add doc for the container format.

So why didn't you add some docs? I support Lukasz's request for a proper 
documentation in some README file. I found it already hard enough to 
find information about the current boot process of the i.MX8 and if you 
need to add even more complexity, please add docs before this gets merged.

> The detailed format could be found in RM
> https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
> Chapter 5.9.4 High Level Container Format
> 
> CI: https://travis-ci.org/MrVan/u-boot/builds/547161366
> 
> Peng Fan (5):
>    imx8: support parsing i.MX8 Container file
>    spl: mmc: support loading i.MX container format file
>    imx: add container target
>    imx8qxp_mek: switch to use container image
>    imx8qm_mek: switch to use container image
> 
>   Makefile                                        |   8 ++
>   arch/arm/include/asm/arch-imx8/image.h          |  56 +++++++++++
>   arch/arm/mach-imx/Makefile                      |  14 ++-
>   arch/arm/mach-imx/imx8/Kconfig                  |  13 +++
>   arch/arm/mach-imx/imx8/Makefile                 |   4 +
>   arch/arm/mach-imx/imx8/parse-container.c        | 120 ++++++++++++++++++++++++
>   board/freescale/imx8qm_mek/README               |   4 +-
>   board/freescale/imx8qm_mek/uboot-container.cfg  |  13 +++
>   board/freescale/imx8qxp_mek/README              |   4 +-
>   board/freescale/imx8qxp_mek/uboot-container.cfg |  13 +++
>   common/spl/spl_mmc.c                            |  10 ++
>   configs/imx8qm_mek_defconfig                    |   8 +-
>   configs/imx8qxp_mek_defconfig                   |   5 +-
>   include/spl.h                                   |  12 +++
>   14 files changed, 270 insertions(+), 14 deletions(-)
>   create mode 100644 arch/arm/include/asm/arch-imx8/image.h
>   create mode 100644 arch/arm/mach-imx/imx8/parse-container.c
>   create mode 100644 board/freescale/imx8qm_mek/uboot-container.cfg
>   create mode 100644 board/freescale/imx8qxp_mek/uboot-container.cfg
>