[U-Boot] [PATCH V3 0/5] add i.MX8 container loading support

[Peng Fan]

> Subject: Re: [U-Boot] [PATCH V3 0/5] add i.MX8 container loading support
> 
> On 22.07.19 10:08, Peng Fan wrote:
> >> Subject: Re: [U-Boot] [PATCH V3 0/5] add i.MX8 container loading
> >> support
> >>
> >> On 22.07.19 04:12, Peng Fan wrote:
> >>> V3:
> >>>    Drops patch 1/5 from V2, add 8QM support, nothing else changed.
> >>>    Stefano,
> >>>    This patchset was pending in patchwork for more that one month,
> >>>    please consider to apply.
> >>
> >> I'm not the one to judge here and I don't know the rules for U-Boot,
> >> but only because they have been pending for a long time, doesn't make
> >> the patches more suitable for upstream. Even more so, if no one has
> reviewed them yet.
> >
> > Since it was there long time, I just thought no one has comments.
> >
> >>
> >>>
> >>> V2:
> >>>    Drop cleanup Makefile since V1, that patch is not correct.
> >>>    Rebased on master
> >>>
> >>> The V2 version:
> >>>
> >> https://patch
> >>
> work.ozlabs.org%2Fcover%2F1118413%2F&data=02%7C01%7Cpeng.fan
> >> %40nxp.com%7C87ccfec5031249de3fde08d70e77fa9a%7C686ea1d3bc2b
> 4c
> >>
> 6fa92cd99c5c301635%7C0%7C1%7C636993780782660409&sdata=xUcj
> >>
> AnqE2WHa2yPppBDx2Og8yv8McyWEaULsJOEzNmk%3D&reserved=0
> >>>
> >>> The V1 version:
> >>>
> >> https://patch
> >>
> work.ozlabs.org%2Fcover%2F1096334%2F&data=02%7C01%7Cpeng.fan
> >> %40nxp.com%7C87ccfec5031249de3fde08d70e77fa9a%7C686ea1d3bc2b
> 4c
> >>
> 6fa92cd99c5c301635%7C0%7C1%7C636993780782660409&sdata=o4
> >> Wbxso8J5HuHlvMvnuKsNK8rDFUSEtItv0Yh0ITeQg%3D&reserved=0
> >>>
> >>> This patchset is to support i.MX8 container loading from SPL,
> >>> i.MX8 AHAB secure boot not support FIT image, so we need to use
> >>> container image.
> >>>
> >>> Currently still use a fixed offset for the 2nd
> >>> container(u-boot.cnt), future patches will drop this fixed offset
> >>> and use dynamaic offset according to the size of 1st container for spl.
> >>> Only MMC is supported now, future patches will also support
> >> SPI/NOR/NAND
> >>> following similar style as mmc part, if the mmc part is ok.
> >>>
> >>> Based on the comments in
> >> https://patch
> >>
> work.ozlabs.org%2Fpatch%2F1096336%2F&data=02%7C01%7Cpeng.fan
> >> %40nxp.com%7C87ccfec5031249de3fde08d70e77fa9a%7C686ea1d3bc2b
> 4c
> >>
> 6fa92cd99c5c301635%7C0%7C1%7C636993780782660409&sdata=8aH
> >>
> Hmlu%2FZ6g6h20k%2BxIOrPfk3kG4yzwTE93aRucQ%2FCY%3D&reserve
> >> d=0
> >>> So I think we have agreed the approach, the only comments that not
> >>> addressed from Lukasz is add doc for the container format.
> >>
> >> So why didn't you add some docs? I support Lukasz's request for a
> >> proper documentation in some README file. I found it already hard
> >> enough to find information about the current boot process of the
> >> i.MX8 and if you need to add even more complexity, please add docs
> before this gets merged.
> >
> > Not sure you are working i.MX8 and i.MX8M both. Or just i.MX8M.
> > There is a README in the i.MX8QM/QXP board file shows the steps to build
> images.
> > Or you wanna me to put the container format from Reference Manual to
> > U-Boot?
> 
> For now I'm only working on i.MX8M. But if I ever would need to work on
> i.MX8, I would be glad to have a proper documentation of how the container
> format is used in U-Boot and what happens while booting. What happens in
> the different stages, which image is copied to what address and things like
> that.

ok, a file like README.imximage should be ok. V4 will include README.imx8image.

Regards,
Peng.

> 
> Thanks,
> Frieder
> 
> >
> > Regards,
> > Peng.
> >>
> >>> The detailed format could be found in RM
> >>>
> >> https://www.
> >>
> nxp.com%2Fdocs%2Fen%2Freference-manual%2FIMX8DQXPRM.pdf&da
> >>
> ta=02%7C01%7Cpeng.fan%40nxp.com%7C87ccfec5031249de3fde08d70e77f
> >>
> a9a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C636993780782
> >>
> 660409&sdata=PMOVoEX30qwR3XDPBThWFWTU7qqFaaC6SyykGweIi2
> >> E%3D&reserved=0
> >>> Chapter 5.9.4 High Level Container Format
> >>>
> >>> CI:
> >> https://travis-
> >>
> ci.org%2FMrVan%2Fu-boot%2Fbuilds%2F547161366&data=02%7C01%7
> >>
> Cpeng.fan%40nxp.com%7C87ccfec5031249de3fde08d70e77fa9a%7C686ea1
> >>
> d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C636993780782660409&s
> >>
> data=oPp3%2FyB2kpHj4sxi5n1xWPnf21foJ%2FroU21UXskqijM%3D&res
> >> erved=0
> >>>
> >>> Peng Fan (5):
> >>>     imx8: support parsing i.MX8 Container file
> >>>     spl: mmc: support loading i.MX container format file
> >>>     imx: add container target
> >>>     imx8qxp_mek: switch to use container image
> >>>     imx8qm_mek: switch to use container image
> >>>
> >>>    Makefile                                        |   8 ++
> >>>    arch/arm/include/asm/arch-imx8/image.h          |  56
> >> +++++++++++
> >>>    arch/arm/mach-imx/Makefile                      |  14 ++-
> >>>    arch/arm/mach-imx/imx8/Kconfig                  |  13 +++
> >>>    arch/arm/mach-imx/imx8/Makefile                 |   4 +
> >>>    arch/arm/mach-imx/imx8/parse-container.c        | 120
> >> ++++++++++++++++++++++++
> >>>    board/freescale/imx8qm_mek/README               |   4 +-
> >>>    board/freescale/imx8qm_mek/uboot-container.cfg  |  13 +++
> >>>    board/freescale/imx8qxp_mek/README              |   4 +-
> >>>    board/freescale/imx8qxp_mek/uboot-container.cfg |  13 +++
> >>>    common/spl/spl_mmc.c                            |  10 ++
> >>>    configs/imx8qm_mek_defconfig                    |   8 +-
> >>>    configs/imx8qxp_mek_defconfig                   |   5 +-
> >>>    include/spl.h                                   |  12 +++
> >>>    14 files changed, 270 insertions(+), 14 deletions(-)
> >>>    create mode 100644 arch/arm/include/asm/arch-imx8/image.h
> >>>    create mode 100644 arch/arm/mach-imx/imx8/parse-container.c
> >>>    create mode 100644
> board/freescale/imx8qm_mek/uboot-container.cfg
> >>>    create mode 100644
> >>> board/freescale/imx8qxp_mek/uboot-container.cfg
> >>>