[U-Boot] [PATCH v2 4/6] net: phy: mv88E61xx: add config option for mv88E6071 support

[Joe Hershberger]

On Tue, Jul 9, 2019 at 6:26 PM Anatolij Gustschin <agust at denx.de> wrote:
>
> MV88E61XX_88E6020_FAMILY option enables support for switch
> devices 6250/6220/6020/6070/6071.
>
> Signed-off-by: Anatolij Gustschin <agust at denx.de>
> ---
>  drivers/net/phy/Kconfig | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index 2a3da068c9..097b499ba3 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -50,6 +50,13 @@ config MV88E61XX_SWITCH
>
>  if MV88E61XX_SWITCH
>
> +config MV88E61XX_88E6020_FAMILY
> +       bool "Marvell MV88E6020 family support."
> +       help
> +         The driver supports 6172/6176/6240/6352 devices in the
> +         default configuration. Select this option to enable support
> +         for 6250/6220/6020/6070/6071 switches.

Is there a rhyme or reason to the model numbers here? This option
seems oddly named, especially since the help doesn't have the model
numbers in numerical order. Can you make it a choice instead?

E.g...

choice
prompt "MV88E61XX device selection"
default MV88E61XX_88E6172

config MV88E61XX_88E6020
bool "MV88E6020"

[ ... ]

config MV88E61XX_88E6172
bool "MV88E6172"

[ ... ]

config MV88E61XX_88E6352
bool "MV88E6352"

help
  The driver supports 6172/6176/6240/6352 devices in the
  default configuration. Select the device to enable support
  for (e.g. 6020/6070/6071/6220/6250).

endchoice

> +
>  config MV88E61XX_CPU_PORT
>         int "CPU Port"
>
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot