[U-Boot] [PATCH] mmc: relocate code comment

Peng Fan peng.fan at nxp.com
Tue Jul 23 07:54:14 UTC 2019


> Subject: [PATCH] mmc: relocate code comment
> 
> The comment about init op being NULL used to be next to the NULL check
> code. Commit 8ca51e51c182 ("dm: mmc: Add a way to use driver model for
> MMC operations") separated the comment from the code. Put them back
> together.
> 
> Fixes: 8ca51e51c182 ("dm: mmc: Add a way to use driver model for MMC
> operations")
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> ---
>  drivers/mmc/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index
> c9aa13b409ac..eecc7d687e32 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2819,12 +2819,12 @@ int mmc_start_init(struct mmc *mmc)
>  			 MMC_CAP(MMC_LEGACY) | MMC_MODE_1BIT;
> 
>  #if !defined(CONFIG_MMC_BROKEN_CD)
> -	/* we pretend there's no card when init is NULL */
>  	no_card = mmc_getcd(mmc) == 0;
>  #else
>  	no_card = 0;
>  #endif
>  #if !CONFIG_IS_ENABLED(DM_MMC)
> +	/* we pretend there's no card when init is NULL */
>  	no_card = no_card || (mmc->cfg->ops->init == NULL);  #endif
>  	if (no_card) {

Reviewed-by: Peng Fan <peng.fan at nxp.com>

> --
> 2.20.1



More information about the U-Boot mailing list