[U-Boot] [EXT] Re: [PATCH v2] rtc: ds3232/ds3231: Add support to generate 32KHz output for driver module

[Chuanhua Han]

Dear Wolfgang Denk

> -----Original Message-----
> From: Wolfgang Denk <wd at denx.de>
> Sent: 2019年7月23日 23:05
> To: Chuanhua Han <chuanhua.han at nxp.com>
> Cc: lukma at denx.de; trini at konsulko.com; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; u-boot at lists.denx.de
> Subject: [EXT] Re: [PATCH v2] rtc: ds3232/ds3231: Add support to generate
> 32KHz output for driver module
> 
> Caution: EXT Email
> 
> Dear Chuanhua Han,
> 
> In message <20190723095745.37138-1-chuanhua.han at nxp.com> you wrote:
> > This patch add an implementation of the rtc_enable_32khz_output() that
> > uses the driver model i2c APIs.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han at nxp.com>
> > ---
> > Change in v2:
> >       - Add RTC_ENABLE_32KHZ_OUTPUT option so this code compiles
> only
> > in that cases where it is really useful.
> 
> So when exactly is it useful?
> 
> If I understand correctly, there are no users of this code in mainline.  Should
> the patch then not be part of a patch series that adds such users?
> 
> Adding potentially "useful" code just on speculation is not nice
> maintenance-wise.
> 
> I recommend to withdraw this patch and submit it together with some real
> consumer of this feature.
Ok, I will send the current patch together with the one that actually uses this function. Thanks for your advice!
> 
> Thanks.
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "The question of whether a computer can think is no more  interesting than
> the question of whether a submarine can swim"
>                                                 - Edsgar W.  Dijkstra