[U-Boot] [PATCH 2/4] armv8: ls2088aqds: The ls2088aqds board supports the I2C driver model.

Wolfgang Denk wd at denx.de
Wed Jul 24 06:51:06 UTC 2019


Dear Chuanhua Han,

In message <20190724025904.469-2-chuanhua.han at nxp.com> you wrote:
...
>  	/* Set I2c to Slot 1 */
> +#ifndef CONFIG_DM_I2C
>  	i2c_write(0x77, 0, 0, &a, 1);
> +#else
> +	struct udevice *udev;

Please - no declarations in the in the middle of the code (even if
#ifdef'ed).

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wherever you go...There you are.                    - Buckaroo Banzai


More information about the U-Boot mailing list