[U-Boot] [PATCH v2 1/3] pinctrl: nxp: DM_FLAG_PRE_RELOC by default

[Lukasz Majewski]

Hi Igor,

> From: Igor Opaniuk <igor.opaniuk at toradex.com>
> 
> For NXP SoCs we have to set pinmux configuration ASAP (ideally
> before relocation) to get serial console working. Without this we miss
> almost the half of output (U-boot version, CPU defails, Reset cause,
> DRAM details etc.).
> 
> To achieve this we need to force appropriate pinctrl drivers to get
> probed before relocation.
> 
> Fixes: cd69e8ef9b ("colibri-imx6ull: migrate pinctrl and regulators
> to dtb/dm") Signed-off-by: Igor Opaniuk <igor.opaniuk at toradex.com>
> ---
> 

Reviewed-by: Lukasz Majewski <lukma at denx.de>

BTW: I did the same for serial_mxc.c driver:
https://gitlab.denx.de/u-boot/custodians/u-boot-imx/commit/1b8c986b684c481d2a3a87200e80421129abe32e

> v2:
> - Addressed same issue for all NXP pinctrl drivers
> 
>  drivers/pinctrl/nxp/pinctrl-imx5.c    | 2 --
>  drivers/pinctrl/nxp/pinctrl-imx6.c    | 2 --
>  drivers/pinctrl/nxp/pinctrl-imx7.c    | 2 --
>  drivers/pinctrl/nxp/pinctrl-imx7ulp.c | 2 --
>  4 files changed, 8 deletions(-)
> 
> diff --git a/drivers/pinctrl/nxp/pinctrl-imx5.c
> b/drivers/pinctrl/nxp/pinctrl-imx5.c index 4e831b6f39..5d17380919
> 100644 --- a/drivers/pinctrl/nxp/pinctrl-imx5.c
> +++ b/drivers/pinctrl/nxp/pinctrl-imx5.c
> @@ -40,7 +40,5 @@ U_BOOT_DRIVER(imx5_pinctrl) = {
>  	.remove = imx_pinctrl_remove,
>  	.priv_auto_alloc_size = sizeof(struct imx_pinctrl_priv),
>  	.ops = &imx_pinctrl_ops,
> -#if !CONFIG_IS_ENABLED(OF_CONTROL)
>  	.flags = DM_FLAG_PRE_RELOC,
> -#endif
>  };
> diff --git a/drivers/pinctrl/nxp/pinctrl-imx6.c
> b/drivers/pinctrl/nxp/pinctrl-imx6.c index 0c1e7a9c05..aafa3057ad
> 100644 --- a/drivers/pinctrl/nxp/pinctrl-imx6.c
> +++ b/drivers/pinctrl/nxp/pinctrl-imx6.c
> @@ -49,7 +49,5 @@ U_BOOT_DRIVER(imx6_pinctrl) = {
>  	.remove = imx_pinctrl_remove,
>  	.priv_auto_alloc_size = sizeof(struct imx_pinctrl_priv),
>  	.ops = &imx_pinctrl_ops,
> -#if !CONFIG_IS_ENABLED(OF_CONTROL)
>  	.flags = DM_FLAG_PRE_RELOC,
> -#endif
>  };
> diff --git a/drivers/pinctrl/nxp/pinctrl-imx7.c
> b/drivers/pinctrl/nxp/pinctrl-imx7.c index 8776fd9650..769d428dda
> 100644 --- a/drivers/pinctrl/nxp/pinctrl-imx7.c
> +++ b/drivers/pinctrl/nxp/pinctrl-imx7.c
> @@ -37,7 +37,5 @@ U_BOOT_DRIVER(imx7_pinctrl) = {
>  	.remove = imx_pinctrl_remove,
>  	.priv_auto_alloc_size = sizeof(struct imx_pinctrl_priv),
>  	.ops = &imx_pinctrl_ops,
> -#if !CONFIG_IS_ENABLED(OF_CONTROL)
>  	.flags = DM_FLAG_PRE_RELOC,
> -#endif
>  };
> diff --git a/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
> b/drivers/pinctrl/nxp/pinctrl-imx7ulp.c index d778f82aac..598bbfaf35
> 100644 --- a/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
> +++ b/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
> @@ -41,7 +41,5 @@ U_BOOT_DRIVER(imx7ulp_pinctrl) = {
>  	.remove = imx_pinctrl_remove,
>  	.priv_auto_alloc_size = sizeof(struct imx_pinctrl_priv),
>  	.ops = &imx_pinctrl_ops,
> -#if !CONFIG_IS_ENABLED(OF_CONTROL)
>  	.flags = DM_FLAG_PRE_RELOC,
> -#endif
>  };




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190724/d981ceb4/attachment.sig>