[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

Tom Rini trini at konsulko.com
Thu Jul 25 15:13:23 UTC 2019


On Thu, Jul 25, 2019 at 04:33:21PM +0300, Sam Protsenko wrote:
> Hi Simon,
> 
> On Sat, Jul 6, 2019 at 7:53 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > Hi,
> >
> > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko at linaro.org> wrote:
> > >
> > > Signed-off-by: Sam Protsenko <semen.protsenko at linaro.org>
> > > ---
> > >  test/py/tests/{ => test_android}/test_avb.py | 0
> > >  1 file changed, 0 insertions(+), 0 deletions(-)
> > >  rename test/py/tests/{ => test_android}/test_avb.py (100%)
> > >
> > > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> > > similarity index 100%
> > > rename from test/py/tests/test_avb.py
> > > rename to test/py/tests/test_android/test_avb.py
> > > --
> >
> > I'd prefer to keep tsts in one place. What is the goal of this patch?
> >
> 
> Similar patch was merged recently (adding test_android/ dir):
> 
>     https://patchwork.ozlabs.org/patch/1128013/
> 
> So we need either:
>   1. move that test out of test_android/ dir, and drop this one
>   2. or apply this patch
> 
> What would you prefer? (I've explained my perspective on that matter
> earlier in this thread). We should do either (1) or (2) to keep the
> consistency.

Note that we've also had vboot as a sub-directory since it was
introduced and test_fs is also a sub-directory.  My two cents is that
sub-directories help with organization as the number of tests increase.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190725/8cc59ef6/attachment.sig>


More information about the U-Boot mailing list