[U-Boot] [PATCH v3 2/4] armv8: ls2088aqds: The ls2088aqds board supports the I2C driver model.
Chuanhua Han
chuanhua.han at nxp.com
Fri Jul 26 03:27:27 UTC 2019
This patch is updating ls2088aqds board init code to support DM_I2C.
Signed-off-by: Chuanhua Han <chuanhua.han at nxp.com>
---
depends on:
- http://patchwork.ozlabs.org/project/uboot/list/?series=118772
- http://patchwork.ozlabs.org/project/uboot/list/?series=117226
Changes in v3:
- Delete something about DS3231_BUS_NUM
- Modify the interface and definition of rtc_enable_32khz_output function
Changes in v2:
- No change.
board/freescale/ls2080aqds/eth.c | 236 ++++++++++++++++++++++++++++----
board/freescale/ls2080aqds/ls2080aqds.c | 16 +++
include/configs/ls2080aqds.h | 3 +
3 files changed, 228 insertions(+), 27 deletions(-)
diff --git a/board/freescale/ls2080aqds/eth.c b/board/freescale/ls2080aqds/eth.c
index f706fd4..710f075 100644
--- a/board/freescale/ls2080aqds/eth.c
+++ b/board/freescale/ls2080aqds/eth.c
@@ -105,9 +105,20 @@ static void sgmii_configure_repeater(int serdes_port)
uint8_t ch_b_ctl2[] = {0x81, 0x82, 0x83, 0x84};
int *riser_phy_addr = &xqsgii_riser_phy_addr[0];
+#ifdef CONFIG_DM_I2C
+ struct udevice *udev;
+#endif
/* Set I2c to Slot 1 */
- i2c_write(0x77, 0, 0, &a, 1);
+#ifndef CONFIG_DM_I2C
+ ret = i2c_write(0x77, 0, 0, &a, 1);
+#else
+ ret = i2c_get_chip_for_busnum(0, 0x77, 1, &udev);
+ if (!ret)
+ ret = dm_i2c_write(udev, 0, &a, 1);
+#endif
+ if (ret)
+ goto error;
for (dpmac = 0; dpmac < 8; dpmac++) {
/* Check the PHY status */
@@ -120,7 +131,15 @@ static void sgmii_configure_repeater(int serdes_port)
mii_bus = 1;
dpmac_id = dpmac + 9;
a = 0xb;
- i2c_write(0x76, 0, 0, &a, 1);
+#ifndef CONFIG_DM_I2C
+ ret = i2c_write(0x76, 0, 0, &a, 1);
+#else
+ ret = i2c_get_chip_for_busnum(0, 0x76, 1, &udev);
+ if (!ret)
+ ret = dm_i2c_write(udev, 0, &a, 1);
+#endif
+ if (ret)
+ goto error;
break;
}
@@ -153,29 +172,102 @@ static void sgmii_configure_repeater(int serdes_port)
for (i = 0; i < 4; i++) {
for (j = 0; j < 4; j++) {
+#ifndef CONFIG_DM_I2C
a = 0x18;
- i2c_write(i2c_addr[dpmac], 6, 1, &a, 1);
+ ret = i2c_write(i2c_addr[dpmac], 6, 1, &a, 1);
+ if (ret)
+ goto error;
a = 0x38;
- i2c_write(i2c_addr[dpmac], 4, 1, &a, 1);
+ ret = i2c_write(i2c_addr[dpmac], 4, 1, &a, 1);
+ if (ret)
+ goto error;
a = 0x4;
- i2c_write(i2c_addr[dpmac], 8, 1, &a, 1);
+ ret = i2c_write(i2c_addr[dpmac], 8, 1, &a, 1);
+ if (ret)
+ goto error;
- i2c_write(i2c_addr[dpmac], 0xf, 1,
- &ch_a_eq[i], 1);
- i2c_write(i2c_addr[dpmac], 0x11, 1,
- &ch_a_ctl2[j], 1);
+ ret = i2c_write(i2c_addr[dpmac], 0xf,
+ 1, &ch_a_eq[i], 1);
+ if (ret)
+ goto error;
+ ret = i2c_write(i2c_addr[dpmac], 0x11,
+ 1, &ch_a_ctl2[j], 1);
+ if (ret)
+ goto error;
- i2c_write(i2c_addr[dpmac], 0x16, 1,
- &ch_b_eq[i], 1);
- i2c_write(i2c_addr[dpmac], 0x18, 1,
- &ch_b_ctl2[j], 1);
+ ret = i2c_write(i2c_addr[dpmac], 0x16,
+ 1, &ch_b_eq[i], 1);
+ if (ret)
+ goto error;
+ ret = i2c_write(i2c_addr[dpmac], 0x18,
+ 1, &ch_b_ctl2[j], 1);
+ if (ret)
+ goto error;
a = 0x14;
- i2c_write(i2c_addr[dpmac], 0x23, 1, &a, 1);
+ ret = i2c_write(i2c_addr[dpmac],
+ 0x23, 1, &a, 1);
+ if (ret)
+ goto error;
a = 0xb5;
- i2c_write(i2c_addr[dpmac], 0x2d, 1, &a, 1);
+ ret = i2c_write(i2c_addr[dpmac],
+ 0x2d, 1, &a, 1);
+ if (ret)
+ goto error;
a = 0x20;
- i2c_write(i2c_addr[dpmac], 4, 1, &a, 1);
+ ret = i2c_write(i2c_addr[dpmac], 4, 1, &a, 1);
+ if (ret)
+ goto error;
+#else
+ ret = i2c_get_chip_for_busnum(0,
+ i2c_addr[dpmac],
+ 1, &udev);
+ if (!ret) {
+ a = 0x18;
+ ret = dm_i2c_write(udev, 6, &a, 1);
+ if (ret)
+ goto error;
+ a = 0x38;
+ ret = dm_i2c_write(udev, 4, &a, 1);
+ if (ret)
+ goto error;
+ a = 0x4;
+ ret = dm_i2c_write(udev, 8, &a, 1);
+ if (ret)
+ goto error;
+
+ ret = dm_i2c_write(udev, 0xf,
+ &ch_a_eq[i], 1);
+ if (ret)
+ goto error;
+ ret = dm_i2c_write(udev, 0x11,
+ &ch_a_ctl2[j], 1);
+ if (ret)
+ goto error;
+
+ ret = dm_i2c_write(udev, 0x16,
+ &ch_b_eq[i], 1);
+ if (ret)
+ goto error;
+ ret = dm_i2c_write(udev, 0x18,
+ &ch_b_ctl2[j], 1);
+ if (ret)
+ goto error;
+ a = 0x14;
+ ret = dm_i2c_write(udev, 0x23, &a, 1);
+ if (ret)
+ goto error;
+ a = 0xb5;
+ ret = dm_i2c_write(udev, 0x2d, &a, 1);
+ if (ret)
+ goto error;
+ a = 0x20;
+ ret = dm_i2c_write(udev, 4, &a, 1);
+ if (ret)
+ goto error;
+ }
+
+#endif
mdelay(100);
ret = miiphy_read(dev[mii_bus],
riser_phy_addr[dpmac],
@@ -229,9 +321,20 @@ static void qsgmii_configure_repeater(int dpmac)
const char *dev = "LS2080A_QDS_MDIO0";
int ret = 0;
unsigned short value;
+#ifdef CONFIG_DM_I2C
+ struct udevice *udev;
+#endif
/* Set I2c to Slot 1 */
- i2c_write(0x77, 0, 0, &a, 1);
+#ifndef CONFIG_DM_I2C
+ ret = i2c_write(0x77, 0, 0, &a, 1);
+#else
+ ret = i2c_get_chip_for_busnum(0, 0x77, 1, &udev);
+ if (!ret)
+ ret = dm_i2c_write(udev, 0, &a, 1);
+#endif
+ if (ret)
+ goto error;
switch (dpmac) {
case 1:
@@ -282,25 +385,104 @@ static void qsgmii_configure_repeater(int dpmac)
for (i = 0; i < 4; i++) {
for (j = 0; j < 4; j++) {
+#ifndef CONFIG_DM_I2C
a = 0x18;
- i2c_write(i2c_phy_addr, 6, 1, &a, 1);
+ ret = i2c_write(i2c_phy_addr, 6, 1, &a, 1);
+ if (ret)
+ goto error;
a = 0x38;
- i2c_write(i2c_phy_addr, 4, 1, &a, 1);
+ ret = i2c_write(i2c_phy_addr, 4, 1, &a, 1);
+ if (ret)
+ goto error;
a = 0x4;
- i2c_write(i2c_phy_addr, 8, 1, &a, 1);
+ ret = i2c_write(i2c_phy_addr, 8, 1, &a, 1);
+ if (ret)
+ goto error;
- i2c_write(i2c_phy_addr, 0xf, 1, &ch_a_eq[i], 1);
- i2c_write(i2c_phy_addr, 0x11, 1, &ch_a_ctl2[j], 1);
+ ret = i2c_write(i2c_phy_addr, 0xf, 1, &ch_a_eq[i], 1);
+ if (ret)
+ goto error;
+ ret = i2c_write(i2c_phy_addr, 0x11, 1,
+ &ch_a_ctl2[j], 1);
+ if (ret)
+ goto error;
- i2c_write(i2c_phy_addr, 0x16, 1, &ch_b_eq[i], 1);
- i2c_write(i2c_phy_addr, 0x18, 1, &ch_b_ctl2[j], 1);
+ ret = i2c_write(i2c_phy_addr, 0x16, 1, &ch_b_eq[i], 1);
+ if (ret)
+ goto error;
+ ret = i2c_write(i2c_phy_addr, 0x18, 1,
+ &ch_b_ctl2[j], 1);
+ if (ret)
+ goto error;
a = 0x14;
- i2c_write(i2c_phy_addr, 0x23, 1, &a, 1);
+ ret = i2c_write(i2c_phy_addr, 0x23, 1, &a, 1);
+ if (ret)
+ goto error;
a = 0xb5;
- i2c_write(i2c_phy_addr, 0x2d, 1, &a, 1);
+ ret = i2c_write(i2c_phy_addr, 0x2d, 1, &a, 1);
+ if (ret)
+ goto error;
a = 0x20;
- i2c_write(i2c_phy_addr, 4, 1, &a, 1);
+ ret = i2c_write(i2c_phy_addr, 4, 1, &a, 1);
+ if (ret)
+ goto error;
+#else
+ ret = i2c_get_chip_for_busnum(0,
+ i2c_phy_addr,
+ 1, &udev);
+ if (!ret) {
+ a = 0x18;
+ ret = dm_i2c_write(udev, 6, &a, 1);
+ if (ret)
+ goto error;
+ a = 0x38;
+ ret = dm_i2c_write(udev, 4, &a, 1);
+ if (ret)
+ goto error;
+ a = 0x4;
+ ret = dm_i2c_write(udev, 8, &a, 1);
+ if (ret)
+ goto error;
+
+ ret = dm_i2c_write(udev, 0xf,
+ &ch_a_eq[i],
+ 1);
+ if (ret)
+ goto error;
+ ret = dm_i2c_write(udev, 0x11,
+ &ch_a_ctl2[j],
+ 1);
+ if (ret)
+ goto error;
+
+ ret = dm_i2c_write(udev, 0x16,
+ &ch_b_eq[i],
+ 1);
+ if (ret)
+ goto error;
+ ret = dm_i2c_write(udev, 0x18,
+ &ch_b_ctl2[j],
+ 1);
+ if (ret)
+ goto error;
+
+ a = 0x14;
+ ret = dm_i2c_write(udev, 0x23, &a, 1);
+ if (ret)
+ goto error;
+ a = 0xb5;
+ ret = dm_i2c_write(udev, 0x2d, &a, 1);
+ if (ret)
+ goto error;
+ a = 0x20;
+ ret = dm_i2c_write(udev, 4, &a, 1);
+ if (ret)
+ goto error;
+ }
+
+#endif
+
mdelay(100);
ret = miiphy_read(dev, phy_addr, 0x11, &value);
if (ret > 0)
diff --git a/board/freescale/ls2080aqds/ls2080aqds.c b/board/freescale/ls2080aqds/ls2080aqds.c
index a0a3301..ec22cf8 100644
--- a/board/freescale/ls2080aqds/ls2080aqds.c
+++ b/board/freescale/ls2080aqds/ls2080aqds.c
@@ -161,7 +161,15 @@ int select_i2c_ch_pca9547(u8 ch)
{
int ret;
+#ifndef CONFIG_DM_I2C
ret = i2c_write(I2C_MUX_PCA_ADDR_PRI, 0, 1, &ch, 1);
+#else
+ struct udevice *dev;
+
+ ret = i2c_get_chip_for_busnum(0, I2C_MUX_PCA_ADDR_PRI, 1, &dev);
+ if (!ret)
+ ret = dm_i2c_write(dev, 0, &ch, 1);
+#endif
if (ret) {
puts("PCA: failed to select proper channel\n");
return ret;
@@ -224,7 +232,15 @@ int board_init(void)
gd->env_addr = (ulong)&default_environment[0];
#endif
select_i2c_ch_pca9547(I2C_MUX_CH_DEFAULT);
+
+#ifdef CONFIG_RTC_ENABLE_32KHZ_OUTPUT
+#ifdef CONFIG_DM_I2C
+ rtc_enable_32khz_output(0, CONFIG_SYS_I2C_RTC_ADDR);
+#else
rtc_enable_32khz_output();
+#endif
+#endif
+
#ifdef CONFIG_FSL_CAAM
sec_init();
#endif
diff --git a/include/configs/ls2080aqds.h b/include/configs/ls2080aqds.h
index 18f30b5..05ff770 100644
--- a/include/configs/ls2080aqds.h
+++ b/include/configs/ls2080aqds.h
@@ -16,7 +16,9 @@ unsigned long get_board_ddr_clk(void);
#ifdef CONFIG_FSL_QSPI
#define CONFIG_QIXIS_I2C_ACCESS
+#ifndef CONFIG_DM_I2C
#define CONFIG_SYS_I2C_EARLY_INIT
+#endif
#define CONFIG_SYS_I2C_IFDR_DIV 0x7e
#endif
@@ -324,6 +326,7 @@ unsigned long get_board_ddr_clk(void);
*/
#define RTC
#define CONFIG_RTC_DS3231 1
+#define CONFIG_RTC_ENABLE_32KHZ_OUTPUT
#define CONFIG_SYS_I2C_RTC_ADDR 0x68
/* EEPROM */
--
2.9.5
More information about the U-Boot
mailing list