[U-Boot] [EXT] Re: [PATCH v2 4/4] armv8: ls2088aqds : Add ds3232 node

[Chuanhua Han]

> -----Original Message-----
> From: Wolfgang Denk <wd at denx.de>
> Sent: 2019年7月26日 14:26
> To: Chuanhua Han <chuanhua.han at nxp.com>
> Cc: albert.u.boot at aribaud.net; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; Priyanka Jain <priyanka.jain at nxp.com>;
> Rajesh Bhagat <rajesh.bhagat at nxp.com>; u-boot at lists.denx.de;
> lukma at denx.de; trini at konsulko.com
> Subject: Re: [EXT] Re: [PATCH v2 4/4] armv8: ls2088aqds : Add ds3232 node
> 
> Caution: EXT Email
> 
> Dear Chuanhua Han,
> 
> In message
> <AM6PR04MB43577AAE78F9BC0B12E5D07897C10 at AM6PR04MB4357.eurpr
> d04.prod.outlook.com> you wrote:
> >
> > > Is this bisectable?  You first enable the feature in the code, and
> > > only later add the needed property to the DT?  Should it not be reversed?
> > This should not matter because they are in the same patch set
> 
> You completely miss the point what bisecting means!!
> 
> Yes, of course it _does_ matter, as bisecting may apply only parts of your patch
> series, and omit the rest.  If it selects the commit before the last, the code will
> break.
> 
> Please fix this!
The latest version has been revised
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If
> there was anything that depressed him more than his own  cynicism, it was
> that quite often it still wasn't as cynical as real life.
>                                  - Terry Pratchett, _Guards! Guards!_