[U-Boot] [PATCH 01/16] clk: introduce clk_dev_binded

Lukasz Majewski lukma at denx.de
Mon Jul 29 08:57:33 UTC 2019


Hi Peng,

> Hi Lukasz,
> 
> > Subject: [PATCH 01/16] clk: introduce clk_dev_binded  
> 
> Do you have time to review the patchset? Patches were delegated to
> you.

The i.MX related PR (with base CCF) has been pulled to mainline just
yesteday, so I'm going to rewiew and test your code on top of it (with
buildman) today.

I shall send PR for -clk tomorrow.

Thanks for your patches.

> 
> Thanks,
> Peng.
> 
> > 
> > When support Clock Common Framework, U-Boot use dev for clk tree
> > information, there is no clk->parent. When support composite clk,
> > it contains mux/gate/divider, but the mux/gate/divider is not
> > binded with device. So we could not use dev_get_uclass_priv to get
> > the correct clk_mux/gate/divider. So add clk_dev_binded to let
> > choose the correct method.
> > 
> > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > ---
> >  drivers/clk/clk.c | 8 ++++++++
> >  include/clk.h     | 9 +++++++++
> >  2 files changed, 17 insertions(+)
> > 
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index
> > 7d748c9fc7..39b3087067 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -55,3 +55,11 @@ const char *clk_hw_get_name(const struct clk *hw)
> > {
> >  	return hw->dev->name;
> >  }
> > +
> > +bool clk_dev_binded(struct clk *clk)
> > +{
> > +	if (clk->dev && (clk->dev->flags & DM_FLAG_BOUND))
> > +		return true;
> > +
> > +	return false;
> > +}
> > diff --git a/include/clk.h b/include/clk.h index
> > f8f56d9cf0..2ebc905e04 100644
> > --- a/include/clk.h
> > +++ b/include/clk.h
> > @@ -356,4 +356,13 @@ static inline bool clk_valid(struct clk *clk)
> >   * @return zero on success, or -ENOENT on error
> >   */
> >  int clk_get_by_id(ulong id, struct clk **clkp);
> > +
> > +/**
> > + * clk_dev_binded() - Check whether the clk has a device binded
> > + *
> > + * @clk		A pointer to the clk
> > + *
> > + * @return true on binded, or false on no  */ bool
> > +clk_dev_binded(struct clk *clk);
> >  #endif
> > --
> > 2.16.4  
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/f80b4933/attachment.sig>


More information about the U-Boot mailing list