[U-Boot] [PATCH] usb: ehci-omap: Add Support DM_USB and OF_CONTROL

[Marek Vasut]

On 7/29/19 6:05 PM, Adam Ford wrote:
> On Mon, Jul 29, 2019 at 9:38 AM Marek Vasut <marex at denx.de> wrote:
>>
>> On 7/29/19 3:19 PM, Adam Ford wrote:
>>> On Mon, Jul 29, 2019 at 7:30 AM Marek Vasut <marex at denx.de> wrote:
>>>>
>>>> On 7/29/19 2:16 PM, Adam Ford wrote:
>>>>> On Sun, Jun 30, 2019 at 5:21 PM Adam Ford <aford173 at gmail.com> wrote:
>>>>>>
>>>>>> The omap3.dtsi file shows the usbhshost node with two sub-nodes
>>>>>> for ohci and ehci.  This patch file creates the usbhshost, and
>>>>>> pulls the portX-mode information.  It then locates the EHCI
>>>>>> sub-node, and initializes the EHCI controller with the info
>>>>>> pulled from the usbhshost node.
>>>>>>
>>>>>> There is still more to do since there isn't an actual link
>>>>>> between the 'phys' reference and the corresponding phy driver,
>>>>>> and there is no nop-xceiv driver yet.
>>>>>>
>>>>>> In the meantime, the older style reference to
>>>>>> CONFIG_OMAP_EHCI_PHYx_RESET_GPIO is still needed to pull
>>>>>> the phy out of reset until the phy driver is completed and the
>>>>>> phandle reference is made.
>>>>>>
>>>>>> Signed-off-by: Adam Ford <aford173 at gmail.com>
>>>>>>
>>>>>
>>>>> Marek,
>>>>>
>>>>> Some subsequent patches that were depending on this have been applied
>>>>> already, but they cannot be really useful until this patch is applied.
>>>>> Is there any chance it can be applied?  It will give some of the OMAP3
>>>>> boards the USB EHCI functionality which has been lost for a little
>>>>> while.
>>>>
>>>> Sure, I am kinda busy and don't have enough free time to cope with this.
>>>> Moreover, u-boot-usb/master fails to build:
>>>> https://travis-ci.org/marex/u-boot-usb/builds/563567738
>>>>
>>>> Can you take a look whether it's this patchset that causes it ?
>>>
>>> Marek,
>>>
>>> I looked at the Travis logs, and it looks like the da850evm_nand and
>>> da850evm_direct_nor were failing, so I tried to clone
>>> git clone --depth=50 --branch=master
>>> https://github.com/marex/u-boot-usb.git marex/u-boot-usb based on line
>>> 846 of the Travis log.
>>>
>>> When I built da850evm_nand and da850evm_direct_nor, I could not
>>> replicate either the build error.
>>
>> I see, strange, I can replicate the error.
>>
>> $ make da850evm_nand_defconfig ; make -j9
>> ...
>> drivers/usb/host/ohci-hcd.c: In function ‘usb_lowlevel_init’:
>> drivers/usb/host/ohci-hcd.c:2056:35: error:
>> ‘CONFIG_SYS_USB_OHCI_REGS_BASE’ undeclared (first use in this function);
>> did you mean ‘CONFIG_SYS_USB_OHCI_CPU_INIT’?
>>   gohci.regs = (struct ohci_regs *)CONFIG_SYS_USB_OHCI_REGS_BASE;
>>                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>                                    CONFIG_SYS_USB_OHCI_CPU_INIT
>> drivers/usb/host/ohci-hcd.c:2056:35: note: each undeclared identifier is
>> reported only once for each function it appears in
>>   LD      drivers/usb/musb-new/built-in.o
>> drivers/usb/host/ohci-hcd.c:2060:20: error:
>> ‘CONFIG_SYS_USB_OHCI_SLOT_NAME’ undeclared (first use in this function);
>> did you mean ‘CONFIG_SYS_USB_OHCI_CPU_INIT’?
>>   gohci.slot_name = CONFIG_SYS_USB_OHCI_SLOT_NAME;
>>                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>                     CONFIG_SYS_USB_OHCI_CPU_INIT
>>   LD      drivers/mtd/spi/spi-nor.o
>> make[1]: *** [scripts/Makefile.build:279: drivers/usb/host/ohci-hcd.o]
>> Error 1
>> make: *** [Makefile:1594: drivers/usb/host] Error 2
>> make: *** Waiting for unfinished jobs....
>>
> 
> aford at aford-OptiPlex-7050:~/src/marex/u-boot-usb$ make da850evm_nand_defconfig
>   HOSTCC  scripts/basic/fixdep
>   HOSTCC  scripts/kconfig/conf.o
>   YACC    scripts/kconfig/zconf.tab.c
>   LEX     scripts/kconfig/zconf.lex.c
>   HOSTCC  scripts/kconfig/zconf.tab.o
>   HOSTLD  scripts/kconfig/conf
> #
> # configuration written to .config
> #
> aford at aford-OptiPlex-7050:~/src/marex/u-boot-usb$ make ARCH=arm
> CROSS_COMPILE="arm-linux-" -j8
> scripts/kconfig/conf  --syncconfig Kconfig
>   CHK     include/config.h

Are you sure you're building the correct tree ?

The current top commit is 9812437f976c025775ddd36eede30605d0607ba8