[U-Boot] [PATCH v2 4/6] net: phy: mv88E61xx: add config option for mv88E6071 support

[Joe Hershberger]

On Thu, Jul 25, 2019 at 4:42 PM Anatolij Gustschin <agust at denx.de> wrote:
>
> On Tue, 23 Jul 2019 04:26:17 +0000
> Joe Hershberger joe.hershberger at ni.com wrote:
> ...
> > > +config MV88E61XX_88E6020_FAMILY
> > > +       bool "Marvell MV88E6020 family support."
> > > +       help
> > > +         The driver supports 6172/6176/6240/6352 devices in the
> > > +         default configuration. Select this option to enable support
> > > +         for 6250/6220/6020/6070/6071 switches.
> >
> > Is there a rhyme or reason to the model numbers here? This option
> > seems oddly named, especially since the help doesn't have the model
> > numbers in numerical order. Can you make it a choice instead?
>
> We want to be able to use single U-Boot images which support different
> switches, a choice will make it not possible.

I don't see how choice is any different than what you have here in
that respect. You have a hard-coded selection among families. If you
have a need to run the same binary on multiple switches, then this
option should be removed and the pre-init should be detecting the
target.

-Joe

>
> --
> Anatolij
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot