[U-Boot] [PATCH] i2c: imx_lpi2c: add ipg clk

Peng Fan peng.fan at nxp.com
Tue Jul 30 00:45:52 UTC 2019


> Subject: Re: [PATCH] i2c: imx_lpi2c: add ipg clk
> 
> Hi Peng,
> 
> On Wed, 24 Jul 2019 08:54:16 +0000
> Peng Fan peng.fan at nxp.com wrote:
> ...
> > +++ b/drivers/i2c/imx_lpi2c.c
> > @@ -471,6 +471,17 @@ static int imx_lpi2c_probe(struct udevice *bus)
> >  			dev_err(bus, "Failed to enable per clk\n");
> >  			return ret;
> >  		}
> > +
> > +		ret = clk_get_by_name(bus, "ipg", &i2c_bus->ipg_clk);
> > +		if (ret) {
> > +			dev_err(bus, "Failed to get ipg clk\n");
> > +			return ret;
> > +		}
> 
> imx8dx/imx8qxp device trees do not have ipg clock in I2C nodes, here probing
> will fail. Should we add I2C ipg clock to imx8x dts files?

The dts should be fixed. Seems upstream Linux also not have ipg clk, downstream has
it. Let's fix Linux first.

Thanks,
Peng.

> Or is it required only for imx8qm?
> 
> --
> Anatolij


More information about the U-Boot mailing list