[U-Boot] [PATCH] usb: ehci-omap: Add Support DM_USB and OF_CONTROL

[Heiko Schocher]

Hello Marek, Jean,

as travis build for u-boot-usb.git still fails, see

https://travis-ci.org/marex/u-boot-usb/builds/564952927

just did a bisect (tried to build u200 board) on u-boot-usb.git master:

Reason for build failure is:

67ebbc98a19c35eb42e0fbdb00983ea548647c9d is the first bad commit
commit 67ebbc98a19c35eb42e0fbdb00983ea548647c9d
Author: Jean-Jacques Hiblot <jjhiblot at ti.com>
Date:   Thu Jun 27 15:06:29 2019 +0200

     usb: dwc3: Kconfig: get rid of obsolete mode selection

     The mode selection for the DWC3 is kind of obsolete. The driver does not
     have to be host only or gadget only. This choice is confusing.
     All the remaining callers of dwc3_uboot_init() explicitly set dr_mode
     before calling the function, so none rely on a default behavior.

     Remove the choice menu and keep only the USB_DWC3_GADGET option. Enable it
     by default if USB_GADGET and USB_DWC3 are enabled.
     It must be disabled for the evb-rk3328 as it uses DWC2 for the gadget and
     DWC3 for the host.

     Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>

:040000 040000 8eccbadb6c99f6e723989838d7052e9ee9685fb7 4f968001c148a3d0361463dff85f3e6eb4481495 M 
    configs
:040000 040000 6ab49bab2c8ef2b48504ed9f5c921a2c9b34f928 8f071c247ecdf431020bb786c1aea35d328e84b3 M 
    drivers
hs at xmglap:u-boot-usb  [(kein Branch, binäre Suche begonnen bei master)] $ git bisect history
Verwendung: git bisect [help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]
hs at xmglap:u-boot-usb  [(kein Branch, binäre Suche begonnen bei master)] $ git bisect visualize
hs at xmglap:u-boot-usb  [(kein Branch, binäre Suche begonnen bei master)] $ git bisect log
git bisect start
# good: [75551c8bfc9545e31ec2ce238cac3857904007b8] Merge branch '2019-07-26-ti-imports'
git bisect good 75551c8bfc9545e31ec2ce238cac3857904007b8
# bad: [9812437f976c025775ddd36eede30605d0607ba8] fastboot: Remove "bootloader-version" variable
git bisect bad 9812437f976c025775ddd36eede30605d0607ba8
# bad: [942c5da4b141b670d1eefdd650dd3d08648e6c80] configs: k2g_evm_defconfig: disable XHCI_DWC3 and 
enable KEYSTONE_USB_PHY
git bisect bad 942c5da4b141b670d1eefdd650dd3d08648e6c80
# good: [14b619de1fa7417018c8a560a92ce6ed89b567f2] usb: dwc3-generic: add a new host driver that 
uses the dwc3 core
git bisect good 14b619de1fa7417018c8a560a92ce6ed89b567f2
# bad: [67ebbc98a19c35eb42e0fbdb00983ea548647c9d] usb: dwc3: Kconfig: get rid of obsolete mode selection
git bisect bad 67ebbc98a19c35eb42e0fbdb00983ea548647c9d
# good: [2cbadc18b019d0276618e4d4907bf27753d7ce07] usb: dwc3: Add dwc3_of_parse() to get quirks 
information from DT
git bisect good 2cbadc18b019d0276618e4d4907bf27753d7ce07
# first bad commit: [67ebbc98a19c35eb42e0fbdb00983ea548647c9d] usb: dwc3: Kconfig: get rid of 
obsolete mode selection
hs at xmglap:u-boot-usb  [(kein Branch, binäre Suche begonnen bei master)] $

@Jean: Can you please check, and fix the boards which fail?

Thanks!

bye,
Heiko

Am 30.07.2019 um 15:04 schrieb Heiko Schocher:
> Hello Marek,
> 
> Am 30.07.2019 um 14:04 schrieb Marek Vasut:
>> On 7/30/19 7:08 AM, Heiko Schocher wrote:
>>
>> [...]
>>
>> https://travis-ci.org/marex/u-boot-usb/builds/564952927
>>
>> Still fails, now it fails elsewhere though.
> 
> Hmm.. it does not fail anymore for the
> "buildman arm926ejs (non-NXP,siemens,at91,kirkwood,spear)" job!
> 
> Ah [1] was based on commit "f0bfa096dd5c2"
> 
> Your new travis build is based on commit "9812437f976c" ...
> 
> And there are now no problems with
> "buildman arm926ejs (non-NXP,siemens,at91,kirkwood,spear)"
> job!
> 
> good ... remaining in both builds problems with:
> 
> - buildman catch-all AArch64
> 
>     aarch64:  w+   puma-rk3399
> +WARNING: BL31 file bl31.bin NOT found, resulting binary is non-functional
> +Please read Building section in doc/README.rockchip
> +WARNING: PMUM0 file rk3399m0.bin NOT found, resulting binary is non-functional
>     aarch64:  +   u200
> +drivers/usb/gadget/udc/built-in.o: In function `usb_gadget_register_driver':
> +drivers/usb/gadget/udc/udc-core.c:325: multiple definition of `usb_gadget_register_driver'
> +drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:238: first defined here
> +drivers/usb/gadget/udc/built-in.o: In function `usb_gadget_unregister_driver':
> +drivers/usb/gadget/udc/udc-core.c:334: multiple definition of `usb_gadget_unregister_driver'
> +drivers/usb/gadget/built-in.o:drivers/usb/gadget/dwc2_udc_otg.c:287: first defined here
> +make[1]: *** [u-boot] Error 1
> +make: *** [sub-make] Error 2
> 
>    seems like a config problem ... both C files define the same function.
> 
> - buildman rockchip
>    same problem as above
> 
> bye,
> Heiko
> 
> [1] travis build based on "f0bfa096dd5c2"
> https://travis-ci.org/marex/u-boot-usb/builds/563567738
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de