[U-Boot] [PATCH v2 2/2] serial: lpuart: request dm device removal when booting OS

Anatolij Gustschin agust at denx.de
Wed Jul 31 13:11:47 UTC 2019


Hi Peng,

On Mon, 15 Jul 2019 03:02:46 +0000
Peng Fan peng.fan at nxp.com wrote:
... 
> > +static int lpuart_serial_remove(struct udevice *dev) {
> > +	if (dev == gd->cur_serial_dev)
> > +		dev->flags |= DM_FLAG_REMOVE_WITH_PD_ON;  
> 
> How about introduce a device tree property for DM? Then
> Set the flags in common code, not in specific driver.

we should not add more DT properties which are not describing the
hardware, I think. Current plan is to drop this patch and do additional
check dev != gd->cur_serial_dev in device_remove(), as Lokesh suggested.

--
Anatolij


More information about the U-Boot mailing list