[U-Boot] [PATCH] ARM: imx: cm_fx6: Drop ad-hoc SATA binding

[Marek Vasut]

On 6/10/19 4:24 PM, Stefano Babic wrote:
> Hi Marek,
> 
> On 12/05/19 22:43, Marek Vasut wrote:
>> Drop the ad-hoc AHCI binding code, this is superseded by
>> CONFIG_DWC_AHSATA_AHCI=y resp. drivers/ata/dwc_ahsata.c
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Christopher Spinrath <christopher.spinrath at rwth-aachen.de>
>> Cc: Fabio Estevam <fabio.estevam at nxp.com>
>> Cc: Igor Grinberg <grinberg at compulab.co.il>
>> Cc: Nikita Kiryanov <nikita at compulab.co.il>
>> Cc: Stefano Babic <sbabic at denx.de>
>> ---
>>  board/compulab/cm_fx6/cm_fx6.c | 63 ----------------------------------
>>  configs/cm_fx6_defconfig       |  1 -
>>  2 files changed, 64 deletions(-)
>>
>> diff --git a/board/compulab/cm_fx6/cm_fx6.c b/board/compulab/cm_fx6/cm_fx6.c
>> index d42f57d4b7..b8f15cf3ab 100644
>> --- a/board/compulab/cm_fx6/cm_fx6.c
>> +++ b/board/compulab/cm_fx6/cm_fx6.c
>> @@ -724,66 +724,3 @@ U_BOOT_DEVICE(cm_fx6_serial) = {
>>  	.name	= "serial_mxc",
>>  	.platdata = &cm_fx6_mxc_serial_plat,
>>  };
>> -
>> -#if CONFIG_IS_ENABLED(AHCI)
>> -static int sata_imx_probe(struct udevice *dev)
>> -{
>> -	int i, err;
>> -
>> -	/* Make sure this gpio has logical 0 value */
>> -	gpio_direction_output(CM_FX6_SATA_PWLOSS_INT, 0);
>> -	udelay(100);
>> -	cm_fx6_sata_power(1);
> 
> cm_fx6_sata_power() is still defined and not used in the board, this
> raises at least a warning (apart of Christopher's comments).
> 

AFAIR Christopher will be fixing this patch, so drop it.

-- 
Best regards,
Marek Vasut