[U-Boot] [PATCH v3 2/2] xilinx_xiic: Fix transfer initialisation

[Heiko Schocher]

Hello Tomas,

Am 28.06.2019 um 14:13 schrieb Melin Tomas:
> Hi,
> 
> On 6/28/19 3:08 PM, Melin Tomas wrote:
>> Prior to starting a new transfer, conditionally wait for bus to not
>> be busy.
>>
>> Reinitialise controller as otherwise operation is not stable.
>> For reference, see linux kernel commit: 9656eeebf3f1 ("i2c: Revert
>> "i2c: xiic: Do not reset controller before every transfer"")
>>
>> Signed-off-by: Tomas Melin <tomas.melin at vaisala.com>
>> ---
>>
>> Changes in v2:
>> - Change variable declaration order
>> - Change timeout to 3ms
>>
>> Changes in v3:
>> - Change timeout to 1000ms
>> - Add print in case of timeout
>>
>>    drivers/i2c/xilinx_xiic.c | 12 ++++++++++++
>>    1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/i2c/xilinx_xiic.c b/drivers/i2c/xilinx_xiic.c
>> index e4ca0ab936..afb5f21b75 100644
>> --- a/drivers/i2c/xilinx_xiic.c
>> +++ b/drivers/i2c/xilinx_xiic.c
>> @@ -266,8 +266,20 @@ static void xiic_reinit(struct xilinx_xiic_priv *priv)
>>    
>>    static int xilinx_xiic_xfer(struct udevice *dev, struct i2c_msg *msg, int nmsgs)
>>    {
>> +	struct xilinx_xiic_priv *priv = dev_get_priv(dev);
>>    	int ret = 0;
>>    
>> +	ret = wait_for_bit_8(priv->base + XIIC_SR_REG_OFFSET,
>> +			     XIIC_SR_BUS_BUSY_MASK, false, 1000, true);
>> +
>> +	if (ret == -ETIMEDOUT)
>> +		dev_err(dev, "timeout waiting for bus not busy condition");
> 
> If patch otherwise ok, please amend this line before applying by adding
> missing '\n'.
> 
> if required, I can ofcourse send a v4.

I fixed that, also this and patch 1/2 has some style issues:

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 
'commit fatal: mehrd ("1': unbekannter Commit oder Pfad existiert nicht")'
#127:
For reference, see linux kernel commit: 9656eeebf3f1 ("i2c: Revert

ERROR: DOS line endings
#152: FILE: drivers/i2c/xilinx_xiic.c:269:
+^Istruct xilinx_xiic_priv *priv = dev_get_priv(dev);^M$

ERROR: DOS line endings
#155: FILE: drivers/i2c/xilinx_xiic.c:272:
+^Iret = wait_for_bit_8(priv->base + XIIC_SR_REG_OFFSET,^M$

ERROR: DOS line endings
#156: FILE: drivers/i2c/xilinx_xiic.c:273:
+^I^I^I     XIIC_SR_BUS_BUSY_MASK, false, 1000, true);^M$

ERROR: DOS line endings
#157: FILE: drivers/i2c/xilinx_xiic.c:274:
+^M$

ERROR: DOS line endings
#158: FILE: drivers/i2c/xilinx_xiic.c:275:
+^Iif (ret == -ETIMEDOUT)^M$

ERROR: DOS line endings
#159: FILE: drivers/i2c/xilinx_xiic.c:276:
+^I^Idev_err(dev, "timeout waiting for bus not busy condition");^M$

ERROR: DOS line endings
#160: FILE: drivers/i2c/xilinx_xiic.c:277:
+^M$

ERROR: DOS line endings
#161: FILE: drivers/i2c/xilinx_xiic.c:278:
+^Iif (ret)^M$

ERROR: DOS line endings
#162: FILE: drivers/i2c/xilinx_xiic.c:279:
+^I^Ireturn ret;^M$

ERROR: DOS line endings
#163: FILE: drivers/i2c/xilinx_xiic.c:280:
+^M$

ERROR: DOS line endings
#164: FILE: drivers/i2c/xilinx_xiic.c:281:
+^Ixiic_reinit(priv);^M$

ERROR: DOS line endings
#165: FILE: drivers/i2c/xilinx_xiic.c:282:
+^M$

total: 13 errors, 0 warnings, 0 checks, 20 lines checked

patch 1/2:
ERROR: DOS line endings
#147: FILE: drivers/i2c/xilinx_xiic.c:152:
+^I^Iif ((msg->len - pos == 0) && nmsgs == 1) {^M$

I fixed them too, see:
https://github.com/hsdenx/u-boot-i2c/commits/devel

travis build started:
https://travis-ci.org/hsdenx/u-boot-i2c/builds/551762033

If there is a need for v4 please use them as base, thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de