[U-Boot] [PATCH] ARM: rmobile: Convert to bootm_size

Eugeniu Rosca roscaeugeniu at gmail.com
Tue Mar 5 18:42:39 UTC 2019


Hello Marek,

May I ask for your opinion on Renesas commits [1-2] especially in
light of the `bootm_size` changes done in your patch?
The topics look orthogonal to me, but I kindly ask for your confirmation.

Also, purely related to the `bootm_size` patch, compiling v2019.04-rc3
U-Boot for H3-Salvator-X with the diff [3] applied, I get:

common/image.c: In function 'env_get_bootm_mapsize':
common/image.c:520:2: error: #error "Take bootm_size from CONFIG"
 #error "Take bootm_size from CONFIG"
  ^~~~~

Does this mean the "CONFIG_SYS_BOOTMAPSZ" definition has to be removed
from include/configs/rcar-gen3-common.h, to allow the patch to have
the desired effect?

[1] https://github.com/renesas-rcar/u-boot/commit/86ad30910df818
("arm: rcar_gen3: Add skip of relocation")
[2] https://github.com/renesas-rcar/u-boot/commit/91e27e4cc463e ("arm:
rcar_gen3: Add skip of relocation")
[3] Brutal way to reveal the active bootm_size:
diff --git a/common/image.c b/common/image.c
index 4d4248f234fb..d65de506060b 100644
--- a/common/image.c
+++ b/common/image.c
@@ -517,8 +517,10 @@ phys_size_t env_get_bootm_mapsize(void)
        }

 #if defined(CONFIG_SYS_BOOTMAPSZ)
+#error "Take bootm_size from CONFIG"
        return CONFIG_SYS_BOOTMAPSZ;
 #else
+#error "Take bootm_size from env"
        return env_get_bootm_size();
 #endif
 }

Thanks,
Eugeniu.


More information about the U-Boot mailing list