[U-Boot] [PATCH] common: spl_fit: Allow firmware image if no loadables

Fabio Estevam festevam at gmail.com
Thu Mar 7 17:08:10 UTC 2019


Hi Abel,

On Wed, Mar 6, 2019 at 8:48 AM Abel Vesa <abel.vesa at nxp.com> wrote:
>
> If CONFIG_SPL_OS_BOOT and FIT_IMAGE_TINY are enabled,
> the os will not be set to anything and therefore will
> remain as IH_OS_INVALID. What's needed here is to
> have IH_OS_U_BOOT as default. And since using the
> mkimage oneline command (that is, no its file), the
> loadables can't be specified, so we allow firmware
> as a fallback.
>
> Signed-off-by: Abel Vesa <abel.vesa at nxp.com>

This patch causes the following build warning:

CC      spl/common/spl/spl_fit.o
common/spl/spl_fit.c: In function ‘spl_load_simple_fit’:
common/spl/spl_fit.c:484:3: warning: this ‘if’ clause does not
guard... [-Wmisleading-indentation]
   if (node < 0)
   ^~
common/spl/spl_fit.c:487:4: note: ...this statement, but the latter is
misleadingly indented as if it were guarded by the ‘if’
    if (node < 0)
    ^~

This fixes the boot on mx6sabresd. With the build warning fixed you can add:

Tested-by: Fabio Estevam <festevam at gmail.com>


More information about the U-Boot mailing list