[U-Boot] [PATCH 5/6] fdtdec: Implement carveout support functions

Simon Glass sjg at chromium.org
Sun Mar 10 21:51:45 UTC 2019


Hi Thierry,

On Fri, 8 Mar 2019 at 13:11, Thierry Reding <thierry.reding at gmail.com> wrote:
>
> From: Thierry Reding <treding at nvidia.com>
>
> The fdtdec_get_carveout() and fdtdec_set_carveout() function can be used
> to read a carveout from a given node or add a carveout to a given node
> using the standard device tree bindings (involving reserved-memory nodes
> and the memory-region property).
>
> Signed-off-by: Thierry Reding <treding at nvidia.com>
> ---
>  include/fdtdec.h | 39 ++++++++++++++++++++++
>  lib/fdtdec.c     | 85 ++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 124 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>

Again I worry a bit about adding flattree-only functions. Also, is
there a test? Finally, I think debug() is pretty than printf() for
code size.

Regards,
SImon


More information about the U-Boot mailing list