[U-Boot] [PATCH 1/4] x86: Make sure i8254 is setup correctly before generating beeps

Bin Meng bmeng.cn at gmail.com
Mon Mar 11 14:58:37 UTC 2019


On Mon, Mar 11, 2019 at 5:51 AM Simon Glass <sjg at chromium.org> wrote:
>
> On Tue, 26 Feb 2019 at 02:47, Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > The i8254 timer control IO port (0x43) should be setup correctly
> > by using PIT counter 2 to generate beeps, however in U-Boot other
> > codes like TSC driver utilizes PIT for TSC frequency calibration
> > and configures the counter 2 to a different mode that does not
> > beep. Fix this by always ensuring the PIT counter 2 is correctly
> > initialized so that the i8254 beeper driver works as expected.
> >
> > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > ---
> >
> >  arch/x86/lib/i8254.c | 4 ++++
> >  1 file changed, 4 insertions(+)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list