[U-Boot] [PATCH v2 01/12] ARM: kirkwood: add db-88f6281-bp board

[Stefan Roese]

Hi Chris,

On 13.03.19 08:00, Chris Packham wrote:

<snip>

>>> +/*
>>> + * NS16550 Configuration
>>> + */
>>> +#define CONFIG_SYS_NS16550_SERIAL
>>> +#define CONFIG_SYS_NS16550_REG_SIZE  (-4)
>>> +#define CONFIG_SYS_NS16550_CLK               CONFIG_SYS_TCLK
>>> +#define CONFIG_SYS_NS16550_COM1              KW_UART0_BASE
>>
>> Can't you switch to using DM_SERIAL and use the DT for this
>> instead?
>>
> 
> This is proving harder than anticipated. DM_SERIAL needs SYS_MALLOC_F.
> Kirkwood doesn't currently have this enabled and doing so blows our
> the initial stack space. I've attempted to get this going but still
> running into issues. For now I will probably send v2 without this
> change.

Sure, please go ahead without the DM_SERIAL stuff for now. We can
definitely fix this in a follow-up patch. I just wanted to point
this out, as I stumbled over it while reviewing.

Thanks,
Stefan