[U-Boot] [linux-sunxi] [PATCH 1/3] arm: sunxi: Allow per-platform DRAM ZQ configuration on sun8i

[Paul Kocialkowski]

Hi Julian,

On Thu, 2019-03-14 at 22:19 +1100, Julian Calaby wrote:
> Hi Paul,
> 
> On Thu, Mar 14, 2019 at 9:37 PM Paul Kocialkowski
> <paul.kocialkowski at bootlin.com> wrote:
> > A few sun8i platforms define specific default DRAM ZQ values, but they
> > are not taken in account because of MACH_SUN8I being used for the 123
> > default first.
> > 
> > Replace MACH_SUN8I with the list of platforms that don't have specific
> > DRAM ZQ values, to avoid overwriting the default for those that do.
> > 
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>
> > ---
> >  arch/arm/mach-sunxi/Kconfig | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> > index 74e234cded75..c557c79ef097 100644
> > --- a/arch/arm/mach-sunxi/Kconfig
> > +++ b/arch/arm/mach-sunxi/Kconfig
> > @@ -414,7 +414,9 @@ endif
> > 
> >  config DRAM_ZQ
> >         int "sunxi dram zq value"
> > -       default 123 if MACH_SUN4I || MACH_SUN5I || MACH_SUN6I || MACH_SUN8I
> > +       default 123 if MACH_SUN4I || MACH_SUN5I || MACH_SUN6I || \
> > +                      MACH_SUN8I_A23 || MACH_SUN8I_A33 || MACH_SUN8I_A83T || \
> > +                      MACH_SUNXI_H3_H5
> >         default 127 if MACH_SUN7I
> >         default 14779 if MACH_SUN8I_V3S
> >         default 3881979 if MACH_SUN8I_R40 || MACH_SUN50I_H6
> 
> Would it work if these were just re-ordered so the more specific ones
> come first?

Yes it looks like this would work, but I think it's better to be
explicit and avoid any misunderstanding.

Cheers,

Paul

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com