[U-Boot] [PATCH 1/1] efi_loader: fix build error for freestanding.o

Heinrich Schuchardt xypron.glpk at gmx.de
Thu Mar 14 19:57:59 UTC 2019


On 3/14/19 8:46 PM, Andy Shevchenko wrote:
> On Thu, Mar 14, 2019 at 7:17 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>> On 3/14/19 8:19 AM, Andy Shevchenko wrote:
>>> On Thu, Mar 14, 2019 at 8:43 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> 
>>>> new file mode 120000
>>>> index 00000000000..4b7edd52bd9
>>>> --- /dev/null
>>>> +++ b/lib/efi_selftest/efi_freestanding.c
>>>> @@ -0,0 +1 @@
>>>> +../efi_loader/efi_freestanding.c
>>>
>>>> \ No newline at end of file
>>>
>>> ^^^
>>
>> Hello Andy,
>>
>> on my machine this patch creates a symbolic link file. Did you have any
>> problem applying it?
> 
> Isn't better to create a simple oneliner C-file then?
> 
> #include "../efi_loader/efi_freestanding.c"
> 
> ?
> 
> P.S. Symbolic or other links are a property of FS where you build the
> code on. So, it should go via make rather then Git for my opinion.
> 
Thanks for your suggestion. I remember Alex felt uncomfortable with
dynamic link files. And obviously deep relative paths are not well
supported by make either. I will give it a try.

Best regards

Heinrich


More information about the U-Boot mailing list