[U-Boot] [PATCH v2] ARM: kirkwood: disable dcache for Kirkwood boards

[Stefan Roese]

On 18.03.19 08:51, Chris Packham wrote:
> Prior to commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache
> routines to common file") the kirkwood boards didn't have and dcache
> support. The network and usb drivers rely on this. Set
> CONFIG_SYS_DCACHE_OFF in the Kirkwood specific config.h.
> 
> Reported-by: Leigh Brown <leigh at solinno.co.uk>
> Signed-off-by: Chris Packham <judge.packham at gmail.com>
> ---
> 
> Changes in v2:
> - expand the comment in config.h to provide more info
> 
>   arch/arm/mach-kirkwood/include/mach/config.h | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-kirkwood/include/mach/config.h b/arch/arm/mach-kirkwood/include/mach/config.h
> index fcd903887bff..aea60688c2d3 100644
> --- a/arch/arm/mach-kirkwood/include/mach/config.h
> +++ b/arch/arm/mach-kirkwood/include/mach/config.h
> @@ -26,6 +26,12 @@
>   #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
>   #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
>   #define CONFIG_KIRKWOOD_PCIE_INIT       /* Enable PCIE Port0 for kernel */
> +/*
> + * Disable the dcache. Currently the network driver (mvgbe.c) and USB
> + * EHCI driver (ehci-marvell.c) and possibly others rely on the data
> + * cache being disabled.
> + */
> +#define CONFIG_SYS_DCACHE_OFF

While collecting the queued fixes for the upcoming release, I do
have one question regarding this Kirkwood cache issue (I don't have
such a board here, so I can't test anything):

Do we need this patch applied [1], if the patch from this thread is
applied [2]?

Thanks,
Stefan

[1] http://patchwork.ozlabs.org/patch/1048863/
[2] http://patchwork.ozlabs.org/patch/1057716/