[U-Boot] [PATCH v2] ARM: kirkwood: disable dcache for Kirkwood boards

[Stefan Roese]

Hi Leigh,

On 19.03.19 10:29, Leigh Brown wrote:

<snip>

>>>      While collecting the queued fixes for the upcoming release, I do
>>>      have one question regarding this Kirkwood cache issue (I don't
>>> have
>>>      such a board here, so I can't test anything):
>>>
>>>      Do we need this patch applied [1], if the patch from this thread
>>> is
>>>      applied [2]?
>>>
>>>      Thanks,
>>>      Stefan
>>>
>>>      [1] http://patchwork.ozlabs.org/patch/1048863/
>>>      [2] http://patchwork.ozlabs.org/patch/1057716/
>>>
>>>
>>> I'm pretty sure you just need [2]. I've tested with just that on it's
>>> own and Ethernet works on the kirkwood db. Functionally it's the same
>>> change as Michael's just for more boards.
>>>
>>> Leigh, can you see if [2] above works for you?
>>
>> Patch [1] from Leigh also removes icache_enable() in
>> arch/arm/mach-kirkwood/cpu.c.
>>
>> Not sure if this is still needed? Did any of you run into issues with
>> [1] not applied but with CONFIG_SYS_DCACHE_OFF set?
> 
> When the cache consolidation patch was applied, it added code to enable
> the
> icache much earlier in the process.  Therefore, this line of code to
> enable
> it became superfluous (assuming enabling the icache multiple times does
> nothing).
> 
> I'd suggest removing it if you agree with that statement, to reduce
> possible future confusion.

You mean to remove the icache_enable() call in arch/arm/mach-kirkwood/cpu.c?
Yes, with your explanation above I agree with it. Unfortunately your patch
also sets CONFIG_SYS_DCACHE_OFF for dreamplug which is not needed any more
with Chris's generic approach for Kirkwood. Also I find your patch subject:

Commit "ARM: CPU: arm926ejs: Consolidate cache routines to common file" breaks u-boot on Dreamplug

not optimal. Could you please send a new patch with a short subject and
a small commit message with the background (icache is enabled earlier
in the common code now) to the list? That would be great.
  
Thanks,
Stefan