[U-Boot] [PATCH v2] arm: fix hvc call

[Ibai Erkiaga Elorza]

Hi Tom

> -----Original Message-----
> From: Tom Rini <trini at konsulko.com>
> Sent: 15 March 2019 16:08
> To: Ibai Erkiaga Elorza <IBAIE at xilinx.com>
> Cc: Alexander Graf <agraf at suse.de>; u-boot at lists.denx.de; Sumit Garg
> <sumit.garg at linaro.org>; Heinrich Schuchardt <xypron.glpk at gmx.de>; Albert
> Aribaud <albert.u.boot at aribaud.net>
> Subject: Re: [U-Boot][PATCH v2] arm: fix hvc call
> 
> On Fri, Mar 15, 2019 at 12:13:11PM +0000, Ibai Erkiaga Elorza wrote:
> > Hi Alex,
> >
> > > -----Original Message-----
> > > From: Alexander Graf <agraf at suse.de>
> > > Sent: 25 February 2019 13:09
> > > To: Ibai Erkiaga Elorza <IBAIE at xilinx.com>
> > > Cc: u-boot at lists.denx.de; Sumit Garg <sumit.garg at linaro.org>;
> > > Heinrich Schuchardt <xypron.glpk at gmx.de>; Tom Rini
> > > <trini at konsulko.com>; Albert Aribaud <albert.u.boot at aribaud.net>
> > > Subject: Re: [U-Boot][PATCH v2] arm: fix hvc call
> > >
> > >
> > >
> > > > Am 25.02.2019 um 02:11 schrieb Ibai Erkiaga <ibai.erkiaga-
> > > elorza at xilinx.com>:
> > > >
> > > > HVC call makes use of 6 mandatory arguments rather than 7 in the
> > > > same way as SMC calls. The 7th argument is optional (Client ID)
> > > > for both HVC and SMC but is implemented as 16-bit parameter and
> > > > register R7 or W7. The aim of this patch is just fix compilation
> > > > error due to an invalid asm code in the HVC call so that's why the 7th
> argument is removed.
> > > >
> > > > The issue does not report any error in a normal build as hvc_call
> > > > is not used at all and is optimized by the compiler. Using -O0
> > > > triggers the error so the patch is intended to fix issues on a
> > > > ongoing effor to build U-Boot with -O0.
> > > >
> > > > Signed-off-by: Ibai Erkiaga <ibai.erkiaga-elorza at xilinx.com>
> > >
> > > Reviewed-by: Alexander Graf <agraf at suse.de>
> >
> > Thanks for the review. Do I need to CC somebody else to the patch be
> accepted?
> 
> No, but I'm inclined currently to take for for the next release rather than right
> now, unless there's an important argument I'm missing?  Which happens more
> than I'd care to admit ;)
> 
No rush, I'm pretty new contributor and just wondering if something else was missing after Alexander's Review.

> --
> Tom

Ibai