[U-Boot] [PATCH 08/11] Makefile.spl: Move generate AT91SAM NAND image boot.bin to spl directory

[Stefan Roese]

On 25.03.19 15:22, Eugen.Hristev at microchip.com wrote:
> 
> 
> On 19.03.2019 17:56, Stefan Roese wrote:
>> External E-Mail
>>
>>
>> This patch moves the AT91SAM NAND booting SPL image "boot.bin" which
>> includes the ECC values from the root directory into the spl directory,
>> where all SPL related images are located.
> 
> Hi Stefan,
> 
> Yes, indeed, but someone may be using this fact? Removing it might break
> someone's expectations (scripts). Can we make a copy to spl/ dir and
> leave the boot.bin in the root as-is ?

That would be possible, but I find the solution to move the file
to the correct directory cleaner / better. Who uses this image?
I'm pretty sure that Heiko does.

Heiko, do you have any comments on this SPL binary file move? Is
somebody else using it?

Thanks,
Stefan

> Unless someone has objections of course...
> 
> Eugen
> 
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Cc: Heiko Schocher <hs at denx.de>
>> Cc: Andreas Bießmann <andreas at biessmann.org>
>> Cc: Eugen Hristev <eugen.hristev at microchip.com>
>> ---
>>    scripts/Makefile.spl | 6 +++---
>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
>> index 9d5921606e..37be18da4b 100644
>> --- a/scripts/Makefile.spl
>> +++ b/scripts/Makefile.spl
>> @@ -179,10 +179,10 @@ MKIMAGEFLAGS_boot.bin = -T atmelimage
>>    ifeq ($(CONFIG_SPL_GENERATE_ATMEL_PMECC_HEADER),y)
>>    MKIMAGEFLAGS_boot.bin += -n $(shell $(obj)/../tools/atmel_pmecc_params)
>>    
>> -boot.bin: $(obj)/../tools/atmel_pmecc_params
>> +$(obj)/boot.bin: $(obj)/../tools/atmel_pmecc_params
>>    endif
>>    
>> -boot.bin: $(obj)/u-boot-spl.bin FORCE
>> +$(obj)/boot.bin: $(obj)/u-boot-spl.bin FORCE
>>    	$(call if_changed,mkimage)
>>    else
>>    ifdef CONFIG_ARCH_ZYNQ
>> @@ -225,7 +225,7 @@ endif
>>    endif
>>    
>>    ifeq ($(CONFIG_SYS_SOC),"at91")
>> -ALL-y	+= boot.bin
>> +ALL-y	+= $(obj)/boot.bin
>>    endif
>>    
>>    ALL-$(CONFIG_SPL_X86_16BIT_INIT) += $(obj)/u-boot-x86-16bit-spl.bin
>>

Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de