[U-Boot] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT"

Tom Rini trini at konsulko.com
Mon Mar 25 15:43:48 UTC 2019


On Thu, Mar 14, 2019 at 09:57:42PM +0100, Simon Goldschmidt wrote:

> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51.
> 
> The 'eeprom' command has been converted to work with DM_I2C in a patch
> submitted around the same time as this commit:
> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command")
> 
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> ---
> 
>  cmd/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

As is, nope:
make O=/home/jenkins/u-boot/build-am335x_evm -s am335x_evm_defconfig
make O=/home/jenkins/u-boot/build-am335x_evm -s -j8
../cmd/eeprom.c: In function 'eeprom_rw_block':
../cmd/eeprom.c:149:9: warning: implicit declaration of function 'i2c_read'; did you mean 'ide_read'? [-Wimplicit-function-declaration]
   ret = i2c_read(addr[0], offset, alen - 1, buffer, len);
         ^~~~~~~~
         ide_read
../cmd/eeprom.c:151:9: warning: implicit declaration of function 'i2c_write'; did you mean 'ide_write'? [-Wimplicit-function-declaration]
   ret = i2c_write(addr[0], offset, alen - 1, buffer, len);
         ^~~~~~~~~
         ide_write
cmd/built-in.o: In function `eeprom_rw_block':
/home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:149: undefined reference to `i2c_read'
/home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:151: undefined reference to `i2c_write'
/home/jenkins/u-boot/Makefile:1497: recipe for target 'u-boot' failed
make[1]: *** [u-boot] Error 1
Makefile:148: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190325/d596d293/attachment.sig>


More information about the U-Boot mailing list