[U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

[Eugeniu Rosca]

Hello,

On Thu, Mar 28, 2019 at 03:58:48PM -0400, Tom Rini wrote:
> On Thu, Mar 28, 2019 at 05:30:30PM +0100, Eugeniu Rosca wrote:
> > Hello Igor, All,
> > 
> > On Thu, Mar 21, 2019 at 05:39:36PM +0200, Igor Opaniuk wrote:
> > > Hi Eugeniu,
> > > 
> > > On Fri, Mar 8, 2019 at 7:29 PM Eugeniu Rosca <roscaeugeniu at gmail.com> wrote:
> > [..]
> > > >
> > > > The s/uint8_t/u8/ and s/uint32_t/u32/ conversion creates noise
> > > > comparing the in-tree versus out-of-tree files and will add some
> > > > overhead during integration. I still see a lot of U-Boot code saying
> > > > uint8_t/uint32_t, so I wonder if these can be preserved. BTW, some of
> > > > the patches from this series add code using uint32_t.
> > > 
> > > Agree.
> > 
> > Igor, many thanks for the recent replies.
> > 
> > WRT preserving the contents of the original bootloader_message.h from
> > https://android.googlesource.com/platform/bootable/recovery.git/ , I
> > wonder what's the chance of keeping the CPP comments in place when
> > importing the file in-tree, since it will make the diffs and subsequent
> > integration/updates easier from the source repository. Furthermore, we
> > don't expect any U-Boot specific development to be done in this file
> > in-tree. It should purely reflect the upstream state.
> > 
> > I wonder if there is any official position regarding that from the
> > U-Boot maintainers?
> 
> Yes, for stuff that we're importing from another place, and really
> really aren't touching otherwise, we should avoid changing it.

Tom, thanks for your prompt feedback.

Igor, unless you have any objections/comments, would you kindly leave
the CPP comments in the next revision of "bootloader_message.h", so
that we minimize the future integration/back-porting efforts?

I would also re-iterate on the need to import the header file in a
standalone commit, since certain users need it for implementing
A/B-unrelated use-cases/features (e.g. accessing A/B-unrelated
fields of the BCB, like boot reason [1]).

[1] https://source.android.com/devices/bootloader/boot-reason

Best regards,
Eugeniu.