[U-Boot] [PATCH 1/2] i2c: ihs: Get rid of fpgamap
Mario Six
mario.six at gdsys.cc
Fri Mar 29 08:38:50 UTC 2019
On Thu, Feb 7, 2019 at 6:24 AM Heiko Schocher <hs at denx.de> wrote:
>
> Hello Mario,
>
> Am 28.01.2019 um 09:45 schrieb Mario Six:
> > Since the IHS I2C driver want upstream, the surrounding infrastructure
> > has changed quite a bit (notably, the fpgamap driver was replaced with a
> > regmap driver).
> >
> > Update the driver to work with these changes.
> >
> > Signed-off-by: Mario Six <mario.six at gdsys.cc>
> > ---
> > drivers/i2c/ihs_i2c.c | 57 +++++++++++++++++--------------------------
> > 1 file changed, 23 insertions(+), 34 deletions(-)
>
> Just one nitpick ... what happens if regmap_set/get
> return with an error, I see no error handling ...
> (But in the old version there is also none, so may this
> can/should be added in a second step)
>
> Reviewed-by: Heiko Schocher <hs at denx.de>
>
> Thanks!
>
> This patch is assigned to you, so it is fine for me, if you
> pick it up.
>
> bye,
> Heiko
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
>
Applied to u-boot-mpc83xx/next.
More information about the U-Boot
mailing list