[U-Boot] [PATCH] configs: am57xx_evm: Remove ENV_IS_IN_FAT

[Sam Protsenko]

Hi Faiz,

On Fri, Mar 29, 2019 at 3:24 PM Lokesh Vutla <lokeshvutla at ti.com> wrote:
>
> + Praneeth
>
> On 29/03/19 4:45 PM, Tom Rini wrote:
> > On Fri, Mar 29, 2019 at 01:09:25PM +0530, Faiz Abbas wrote:
> >> Tom,
> >>
> >> On 28/03/19 6:33 PM, Tom Rini wrote:
> >>> On Thu, Mar 28, 2019 at 02:21:03PM +0530, Faiz Abbas wrote:
> >>>
> >>>> With U-boot supporting environment in multiple places, enable only
> >>>> ENV_IS_IN_EMMC.
> >>>>

Can you please describe in more details, which exactly problem you are
trying to fix in this patch? As I understand, we support SD boot in
Linux SDK [1], so saving env in FAT can be useful in this case. Could
this issue be fixed in some other way, rather than dropping
multi-environment feature?

Thanks!

[1] http://software-dl.ti.com/processor-sdk-linux/esd/docs/latest/linux/Foundational_Components_U-Boot.html#sd-emmc-or-usb-storage

> >>>> Signed-off-by: Faiz Abbas <faiz_abbas at ti.com>
> >>>> ---
> >>>>  configs/am57xx_evm_defconfig    | 1 +
> >>>>  configs/am57xx_hs_evm_defconfig | 1 +
> >>>>  2 files changed, 2 insertions(+)
> >>>>
> >>>> diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
> >>>> index 3d71020225..e4f0458d72 100644
> >>>> --- a/configs/am57xx_evm_defconfig
> >>>> +++ b/configs/am57xx_evm_defconfig
> >>>> @@ -35,6 +35,7 @@ CONFIG_OF_CONTROL=y
> >>>>  CONFIG_SPL_OF_CONTROL=y
> >>>>  CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
> >>>>  CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
> >>>> +# CONFIG_ENV_IS_IN_FAT is not set
> >>>>  CONFIG_ENV_IS_IN_MMC=y
> >>>>  CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
> >>>>  CONFIG_DM=y
> >>>
> >>> Is this really a good idea for the config we use for Beagle X15?
> >>
> >> There is an eMMC on beagle X15 which is being used to support android
> >> boot. Do you have any other concerns?
> >
> > Yes, I know there's eMMC, but usually in "maker" type devices we have
> > specifically moved from eMMC to FAT.  Lokesh, are you OK with this
> > change?
>
> This is more of an android requirement who requested for having eMMC as env
> partition. am57xx x15 is one of the board tested along with asop project. I
> guess it is fine to have this change.
>
> Thanks and regards,
> Lokesh
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot