[U-Boot] [RFC v2 1/2] zynqmp: add minimal include files to build a pm_cfg_obj.c

[Michal Simek]

On 29. 03. 19 13:23, Luca Ceresoli wrote:
> Hi Michal,
> 
> On 27/03/19 16:10, Michal Simek wrote:
>> On 21. 03. 19 16:48, Luca Ceresoli wrote:
>>> A following commit will allow U-Boot to pass a configuration object to
>>> the ZynqMP PMU firmware. This configuration object is generated by
>>> Xilinx tools in the form of a C file (pm_cfg_obj.c), which #includes a
>>> few headers with constants definitions.
>>>
>>> In order to allow pm_cfg_obj.c to build, include in U-Boot a minimal
>>> version of those headers files:
>>>
>>>  - pm_defs: a copy of [0], reduced to remove unneeded values
>>>  - pmu_global.h: empty file, it is included but not really needed
>>>  - xil_types.h: just includes common.h which has all the needed types
>>>
>>> [0] https://github.com/Xilinx/embeddedsw/blob/xilinx-v2018.3/lib/sw_services/xilpm/src/common/pm_defs.h
>>>
>>> Signed-off-by: Luca Ceresoli <luca at lucaceresoli.net>
>>> ---
>>>  board/xilinx/zynqmp/pm_defs.h    | 254 +++++++++++++++++++++++++++++++
>>>  board/xilinx/zynqmp/pmu_global.h |   0
>>>  board/xilinx/zynqmp/xil_types.h  |   1 +
>>>  3 files changed, 255 insertions(+)
>>>  create mode 100644 board/xilinx/zynqmp/pm_defs.h
>>>  create mode 100644 board/xilinx/zynqmp/pmu_global.h
>>>  create mode 100644 board/xilinx/zynqmp/xil_types.h
> [...]
>>
>> I found one version of this file with GPL license.
> 
> Of pm_defs.h? Interesting, where can I find it?

it is not publicly available but I have seen that.

> 
>> But even that
>> I think this should be taken as blob and compiled/generated out of
>> u-boot source code. Still pm_cfg_obj.c has no GPL license in it.
> 
> Yes, sure. But still we need a pm_defs.h if we want to obtain a blob out
> of a Xilinx-generated pm_cfg_obj.c, so the GPL'ed file you mentioned
> would be useful.

But pm_cfg_obj.c has xilinx license that's why pm_defs.h shouldn't be
gpl if you want to compile it together.
Anyway firmware blob will get rid of this and code which does this can
use Xilinx license as other standalone code which customers use.

Thanks,
Michal