[U-Boot] [PATCH 1/3] vsprintf: Support phys_addr_t specifier unconditionally

Simon Glass sjg at chromium.org
Sat Mar 30 21:19:27 UTC 2019


On Tue, 12 Mar 2019 at 04:38, Thierry Reding <thierry.reding at gmail.com> wrote:
>
> From: Thierry Reding <treding at nvidia.com>
>
> When phys_addr_t printf specifier support was first introduced in commit
> 1eebd14b7902 ("vsprintf: Add modifier for phys_addr_t"), it was enabled
> only if CONFIG_CMD_NET was selected. Since physical addresses are not
> unique to networking support it doesn't make sense to conditionally add
> it in those cases only. Move support for it outside of the CMD_NET guard
> so that the specifier is always supported.
>
> Signed-off-by: Thierry Reding <treding at nvidia.com>
> ---
>  lib/vsprintf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Is there a code-size impact here? Perhaps instead it should be a new
Kconfig option, implied by CMD_NET?

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon


More information about the U-Boot mailing list