[U-Boot] [PATCH v2 01/50] binman: Don't generate an error in 'text' entry constructor

Bin Meng bmeng.cn at gmail.com
Wed May 1 15:16:09 UTC 2019


On Fri, Apr 26, 2019 at 11:59 AM Simon Glass <sjg at chromium.org> wrote:
>
> It is not good practice to raise an exception in a constructor. In this
> case the 'text' entry may not actually be used, if -i is used to filter
> out the images that get built.
>
> Move the exception to where the data is actually used.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
> Changes in v2: None
>
>  tools/binman/etype/text.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list