[U-Boot] [PATCH 2/2] i2c: mxc_i2c: Fix read and read->write xfers in DM mode

Heiko Schocher hs at denx.de
Thu May 2 05:23:14 UTC 2019


Hello Trent,

Am 30.04.2019 um 18:04 schrieb Trent Piepho:
> On Tue, 2019-04-30 at 06:34 +0200, Heiko Schocher wrote:
>> Hello Trent,
>>
>> Am 16.04.2019 um 00:02 schrieb Trent Piepho:
>>> This is an old driver that supports both device mapped and non-mapped
>>> mode, and covers a wide range of hardware.  It's hard to change without
>>> risking breaking something.  I have to tried to be exceedingly detailed
>>> in this patch, so please excuse the length of the commit essay that
>>> follows.
>>>
>> Thanks for this work!
>>
>> Your patch has
>>
>> total: 64 errors, 2 warnings, 0 checks, 145 lines checked
>>
>> Please fix and send a v2.
>>
>> It would be good to become here some Tested by tags ...
>>
>> Reviewed-by: Heiko Schocher <hs at denx.de>
> 
> My patches are fine before I send them.  They are getting DOS line
> endings added in transit.  It seems Microsoft has recently changed
> their mail server used for office365 to automatically add DOS line
> endings to all text emails.  It didn't use to do this.  It seems the
> only way to avoid this is to use base64 encoding with git send-email.
> It works went I send a test message to myself and export from
> Evolution.  No way to test if the list software can handle it without
> re-sending.
> 
> The patches should be automatically fixed by git am, as it will strip
> DOS endings by default.

Unfortunately, your v2 version has the same problem :-(

I pushed them now to:
https://github.com/hsdenx/u-boot-i2c/commits/master

as I started a travis build, see:
https://travis-ci.org/hsdenx/u-boot-i2c/builds/527155944

Can you please check, if your patches are OK?

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list