[U-Boot] [PATCH u-boot-marvell v2 14/15] arm: mvebu: turris_omnia: add RESET button handling
Stefan Roese
sr at denx.de
Thu May 2 09:43:12 UTC 2019
On 02.05.19 11:39, Marek Behun wrote:
> On Thu, 2 May 2019 08:10:36 +0200
> Stefan Roese <sr at denx.de> wrote:
>
>> I fail to see a real reason to introduce these Kconfig options. Is
>> TURRIS_OMNIA_RSTBTN_OVERWRITE_BOOTCMD enabled for your board? If not
>> it just adds dead code, as no other board will ever enable it. So do
>> you plan to add 2 Omnia build targets, one with and one w/o this
>> option enabled? Or what is your plan here?
>>
>> Thanks,
>> Stefan
>
> My idea was that the users should be able to disable this functionality,
> if they are compiling u-boot themselves, but we are going to ship
> Omnias with this config enabled.
Understood, thanks.
> I can of course remove the Kconfig options and enable this reset button
> handling all times.
Please do so. If someone whats to disable this functionality or change
the reset button bootcmd, then he/she/it must do some changes (defconfig
or code).
Thanks,
Stefan
More information about the U-Boot
mailing list