[U-Boot] [PATCH v2] ARM: am335x: Add phyCORE AM335x R2 support

[Niel Fourie]

Hi All,

Thank you Marek for the feedback. I addressed all of your concerns, the 
most important of is mentioned below:

On 4/25/19 12:52 PM, Marek Vasut wrote:
> The Linux commit from which the DTs came is missing.

Added

> Keep the list sorted alphabetically please. (PHY... is below PCM...)
> 

Fixed. Sorry, that was as howler.

> Just curious , was there ever AM335x_R1 ? Why do we use the _R2 suffix
> here ?> 

The AM335x (without the R2) was the Phytec pcm051. So I stuck with 
adding R2 to distinguish the two. (I don't have a pcm051, so I did not 
want to mess with it.)

>> +#ifndef CONFIG_DM_I2C
> 
> CONFIG_IS_ENABLED(DM_I2C)
>

This one is causing some headaches. I can't find any references to 
CONFIG_SPL_DM_I2C, even though we actually use DM for I2C in the SPL, so 
that change causes things to break a bit. As an improvement, I changed 
the code to use #if defined(CONFIG_DM_I2C) instead of #ifndef. We could 
always simply drop the Non-DM support instead, I guess?

On 4/25/19 12:43 PM, Marek Vasut wrote:> Take a look at
 > configs/am335x_evm_defconfig:CONFIG_DM_USB_GADGET=y
 >
 > Maybe we can at least get rid of some of the hard-coded USB non-DM
 > stuff.

I simply removed the hard-coded USB stuff, as the DM_USB was already 
enabled and working anyways. DM_USB_GADGET was also enabled. Thanks for 
the recommendation.

Best regards,
Niel Fourie

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-21 Fax: +49-8142-66989-80  Email: lusus at denx.de