[U-Boot] [PATCH v3] ARM: am335x: Add phyCORE AM335x R2 support

[Heiko Schocher]

Hello Niel,

Am 02.05.2019 um 11:52 schrieb Niel Fourie:
> Support for Phytech phyCORE AM335x R2 SOM (PCL060) on the Phytec
> phyBOARD-Wega AM335x.
> 
> CPU  : AM335X-GP rev 2.1
> Model: Phytec AM335x phyBOARD-WEGA
> DRAM:  256 MiB
> NAND:  256 MiB
> MMC:   OMAP SD/MMC: 0
> eth0: ethernet at 4a100000
> 
> Working:
>   - Eth0
>   - i2C
>   - MMC/SD
>   - NAND
>   - UART
>   - USB (host)
> 
> Device trees were taken from Linux mainline revision
> 37624b58542fb9f2d9a70e6ea006ef8a5f66c30b
> 
> Signed-off-by: Niel Fourie <lusus at denx.de>
> ---
>   arch/arm/dts/Makefile                      |   3 +-
>   arch/arm/dts/am335x-phycore-som.dtsi       | 322 +++++++++++++++++++++
>   arch/arm/dts/am335x-wega-rdk-u-boot.dtsi   |  40 +++
>   arch/arm/dts/am335x-wega-rdk.dts           |  23 ++
>   arch/arm/dts/am335x-wega.dtsi              | 230 +++++++++++++++
>   arch/arm/mach-omap2/Kconfig                |   1 +
>   arch/arm/mach-omap2/am33xx/Kconfig         |   7 +
>   board/phytec/phycore_am335x_r2/Kconfig     |  15 +
>   board/phytec/phycore_am335x_r2/MAINTAINERS |   7 +
>   board/phytec/phycore_am335x_r2/Makefile    |  11 +
>   board/phytec/phycore_am335x_r2/board.c     | 263 +++++++++++++++++
>   board/phytec/phycore_am335x_r2/board.h     |  24 ++
>   board/phytec/phycore_am335x_r2/mux.c       | 117 ++++++++
>   configs/phycore-am335x-r2-wega_defconfig   |  79 +++++
>   include/configs/phycore_am335x_r2.h        | 130 +++++++++
>   15 files changed, 1271 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm/dts/am335x-phycore-som.dtsi
>   create mode 100644 arch/arm/dts/am335x-wega-rdk-u-boot.dtsi
>   create mode 100644 arch/arm/dts/am335x-wega-rdk.dts
>   create mode 100644 arch/arm/dts/am335x-wega.dtsi
>   create mode 100644 board/phytec/phycore_am335x_r2/Kconfig
>   create mode 100644 board/phytec/phycore_am335x_r2/MAINTAINERS
>   create mode 100644 board/phytec/phycore_am335x_r2/Makefile
>   create mode 100644 board/phytec/phycore_am335x_r2/board.c
>   create mode 100644 board/phytec/phycore_am335x_r2/board.h
>   create mode 100644 board/phytec/phycore_am335x_r2/mux.c
>   create mode 100644 configs/phycore-am335x-r2-wega_defconfig
>   create mode 100644 include/configs/phycore_am335x_r2.h

[...]

> diff --git a/arch/arm/dts/am335x-wega-rdk-u-boot.dtsi b/arch/arm/dts/am335x-wega-rdk-u-boot.dtsi
> new file mode 100644
> index 0000000000..b7678e98ff
> --- /dev/null
> +++ b/arch/arm/dts/am335x-wega-rdk-u-boot.dtsi
> @@ -0,0 +1,40 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2019 DENX Software Engineering GmbH
> + */
> +
> +/ {
> +	chosen {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		bootargs = "console=ttyO0,115200 earlyprintk";
> +		stdout-path = &uart0;
> +	};
> +
> +	ocp {
> +		u-boot,dm-spl;
> +		u-boot,dm-pre-reloc;
> +	};
> +
> +	memory at 80000000 {
> +		u-boot,dm-spl;
> +		u-boot,dm-pre-reloc;
> +	};
> +};

could we move the entries for "ocp" and "memory" to

arch/arm/dts/am33xx-u-boot.dtsi ?

I think, this values are so common, that other am33xx based boards needs
them too ...

> +&scm {
> +	u-boot,dm-spl;
> +	u-boot,dm-pre-reloc;
> +};

May this one too?

Beside of this nitpick:

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de