[U-Boot] [PATCH v2] board/BuR/zynq/brsmarc2: initial commit

Hannes Schmelzer hannes at schmelzer.or.at
Thu May 2 18:34:32 UTC 2019


On 5/2/19 6:06 PM, Michal Simek wrote:
> Hi,
Hi Michal,
> On 02. 05. 19 5:14, Hannes Schmelzer wrote:
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index dfa5b02..2b00129 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -208,6 +208,8 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
>>   	zynq-zc770-xm011-x16.dtb \
>>   	zynq-zc770-xm012.dtb \
>>   	zynq-zc770-xm013.dtb \
>> +	zynq-brsmarc2.dtb \
>> +	zynq-brsmarc2_r512.dtb \
> Can't you detect it if you have 512M version?
> u-boot itself has code for these kind of detection.
>
> long get_ram_size(long *base, long maxsize)
I actually think not,
because i need different ps7_init stuff for the two different RAM chips.
(timing, adress lines, ...) But i will check if i even can drop the two
different dts files.
>
>> +/ {
>> +	model = "BRSMARC2 Zynq SoM";
>> +	compatible = "xlnx,zynq-7000";
>> +
>> +	fset: factory-settings {
>> +		bl-version	= "                                ";
>> +		order-no	= "                                ";
>> +		cpu-order-no	= "                                ";
>> +		hw-revision	= "                                ";
>> +		serial-no	= <0>;
>> +		device-id	= <0x0>;
>> +		parent-id	= <0x0>;
>> +		hw-variant	= <0x0>;
>> +		hw-platform	= <0x0>;
>> +		fram-offset	= <0x0>;
>> +		fram-size	= <0x0>;
>> +		cache-disable	= <0x0>;
>> +		cpu-clock	= <0x0>;
>> +	};
> What's this? No compatible string. This looks quite hacky.
This are factory settings, used by the OS (in this case vxWorks),
to identify on which hardware it runs, and have per device unique stuff 
(serial number).
But you're right, it would be nice to have here some compatible string,
i will change this. Today we just search for the node "factory-setting".
A more comfortable ways would be vxFdtNodeOffsetByCompatible(....)
>
>> +
>> +	aliases {
>> +		ethernet0 = &gem0;
>> +		ethernet1 = &gem1;
>> +		i2c0 = &i2c0;
>> +		serial0 = &uart0;
>> +		spi0 = &qspi;
>> +		mmc0 = &sdhci0;
>> +		fset = &fset;
>> +		can0 = &can0;
>> +		can1 = &can1;
>> +	};
>> +
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0x0 0x10000000>;
>> +	};
>> +
>> +	board {
>> +		status = "okay";
>> +		compatible = "bur,brsmarc2-som";
>> +		usb0mux-gpios = <&gpio0 68 GPIO_ACTIVE_HIGH>;
>> +		usb1mux-gpios = <&gpio0 69 GPIO_ACTIVE_HIGH>;
>> +		powerdown-gpios = <&gpio0 0 GPIO_ACTIVE_LOW>;
>> +		reset-gpios = <&gpio0 9 GPIO_ACTIVE_LOW>;
>> +	};
> Where is mainline dt binding for this?
Nowhere, because u-boot nor linux does use this,
this is only for the vxWorks OS.
>
>> +
>> +	fpga: fpga at 40000000 {
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		status = "disabled";
>> +		compatible = "bur,zynqPL", "simple-bus";
> is bur even recoreded for your company.
No think not, i didn't know so far that this is necessary.
But this is a very good input. Can you give me some hint where i have to 
go for it?
> compatible is wrong.
No, compatible is correct. Because i have my own (bur,) zynqPL driver in 
vxWorks
to handle the FPGA stuff.
>> +		reg = <0x40200000 0x1		/* version registers */
>> +		       0x40200004 0x1>;		/* misc registers */
>> +		bur,upddest = &spi_flash;
>> +		bur,updaddr = <0x100000>;
>> +		bur,updsize = <0x200000>;
> likely undocumented
Right, actually i have no real good documentation along the source of 
the opposite.
The vxWorks driver who handles update in flash.
>
>> +
>> +		plk: plk at 80000000 {
>> +			status = "disabled";
>> +			compatible = "bur,DdVxIoEplSMP";
> ditto
>
>> +			bur,hwtree = "IF9";
>> +			reg = <0x80000000 0x8000>;
>> +			interrupt-parent = <&intc>;
>> +			interrupts = <0 68 4>,
>> +				     <0 84 4>;
>> +			local-mac-address = [ 00 60 65 aa ab ac ];
>> +		};
>> +
>> +		x2x: x2x at 40100000 {
>> +			status = "disabled";
>> +			compatible = "bur,xlk";
> ditoo.
>
>> +			bur,hwtree = "IF10";
>> +			reg = <0x40100000 0x8000
>> +			       0x40108000 0x8000>;
>> +			interrupt-parent = <&intc>;
>> +			interrupts = <0 65 4>;
>> +		};
>> +
>> +		uart2: serial at 40200800 {
>> +			status = "disabled";
>> +			compatible = "ns16550a", "bur,DdVxSf16x5xIO";
>> +			bur,hwtree = "IF8";
>> +			reg = <0x40200800 0x40>;
>> +			interrupt-parent = <&intc>;
>> +			interrupts = <0 66 4>;
>> +			term-gpios = <&gpio0 71 GPIO_ACTIVE_HIGH>;
>> +		};
>> +
>> +		uart3: serial at 40200840 {
>> +			status = "disabled";
>> +			compatible = "ns16550a", "bur,DdVxSf16x5xIO";
>> +			bur,hwtree = "IF9";
>> +			reg = <0x40200840 0x40>;
>> +			interrupt-parent = <&intc>;
>> +			interrupts = <0 67 4>;
>> +			term-gpios = <&gpio0 71 GPIO_ACTIVE_HIGH>;
>> +		};
>> +
>> +		uart4: serial at 40200900 {
>> +			status = "disabled";
>> +			compatible = "ns16550a", "bur,DdVxSf16x5xIO";
>> +			bur,hwtree = "IF20";
>> +			reg = <0x40200900 0x40>;
>> +			interrupt-parent = <&intc>;
>> +			interrupts = <0 88 4>;
>> +		};
>> +
>> +		uart5: serial at 40200A00 {
>> +			status = "disabled";
>> +			compatible = "ns16550a", "bur,DdVxSf16x5xIO";
>> +			bur,hwtree = "IF21";
>> +			reg = <0x40200A00 0x40>;
>> +			interrupt-parent = <&intc>;
>> +			interrupts = <0 90 4>;
>> +		};
> all these PL stuff can't go to mainline.
Please explain me the reason why this PL stuff cannot go mainline?
Maybe a solution cold be to drop those in the mainline dts and then
patch it again into it on the local branch. But that would be a way which
i don't prefer.
>
>> +
>> +&gem0 {
>> +	status = "okay";
>> +	phy-mode = "rgmii-id";
>> +	phy-handle = <&ethernet_phy0>;
>> +	mac-address = [ 00 00 00 00 00 00 ];
> 0 mac is wrong.
No, this zeros are placeholder.
The real MAC-Adresses are get into the dts during u-boot's fdt_fixup(...).
They come from environment, and th environment is setup from some
u-boot script.
>
>> +
>> +	ethernet_phy0: ethernet-phy at 1 {
>> +		ti,ledcr = <0x0480>;
>> +		ti,rgmii-rxclk-shift;
>> +		reg = <1>;
>> +	};
>> +};
>> +
>> +&gem1 {
>> +	status = "okay";
>> +	phy-mode = "rgmii-id";
>> +	phy-handle = <&ethernet_phy1>;
>> +	mac-address = [ 00 00 00 00 00 00 ];
> ditto.
same as eth0.
>
>> +
>> +	ethernet_phy1: ethernet-phy at 3{
> coding style. Comment about phy type would be useful.
Yes, i will provide some compatible node for the used DP83867 phy.
>> +		ti,ledcr = <0x0480>;
>> +		reg = <3>;
>> +	};
>> +};
>> +
>> +&i2c0 {
>> +	u-boot,dm-pre-reloc;
>> +	status = "okay";
>> +	clock-frequency = <100000>;
>> +
>> +	boardtemp: pct2075_0 at 49 {
>> +		#thermal-sensor-cells = <0>;
>> +		compatible = "nxp,pct2075";
>> +		reg = <0x49>;
>> +	};
>> +
>> +	temp_core: tmp431_1 at 4C { /* temp. zynq die */
>> +		#thermal-sensor-cells = <1>;
>> +		compatible = "ti,tmp431";
>> +		reg = <0x4C>;
>> +	};
>> +
>> +	extrtc: rx8571 at 51 {	/* realtime clock */
>> +		compatible = "epson,rx8571";
>> +		reg = <0x51>;
>> +	};
>> +
>> +	resetc: rststm at 60 {	/* reset controller */
>> +		compatible = "bur,rststm";
>> +		reg = <0x60>;
>> +		hit-gpios = <&gpio0 84 GPIO_ACTIVE_HIGH>;
>> +		cooling-min-state = <0>;
>> +		cooling-max-state = <1>;	/* reset gets fired */
>> +		#cooling-cells = <2>;		/* min followed by max */
>> +	};
>> +};
>> +
>> +&i2c1 {
>> +	status = "okay";
>> +	clock-frequency = <100000>;
>> +};
>> +
>> +&sdhci0 {
>> +	status = "okay";
>> +	max-frequency = <25000000>;
>> +};
>> +
>> +&uart0 {
>> +	u-boot,dm-pre-reloc;
>> +	status = "okay";
>> +};
>> +
>> +&qspi {
>> +	u-boot,dm-pre-reloc;
>> +	status = "okay";
>> +	spi-max-frequency = <100000000>;
>> +	spi_flash: spiflash at 0 {
>> +		u-boot,dm-pre-reloc;
>> +		compatible = "spidev", "spi-flash";
>> +		spi-max-frequency = <100000000>;
>> +		reg = <0>;
>> +	};
>> +};
>> +
>> +&usb0 {
>> +	status = "okay";
>> +	dr_mode = "host";
>> +	usb-phy = <&usb_phy0>;
>> +};
>> +
>> +&gpio0 {
>> +	u-boot,dm-pre-reloc;
>> +};
>> +
>> +&can0 {
>> +	status = "disabled";
>> +	bur,hwtree = "IF6";
>> +	term-gpios = <&gpio0 70 GPIO_ACTIVE_HIGH>;
>> +};
>> +
>> +&can1 {
>> +	status = "disabled";
>> +	bur,hwtree = "IF7";
>> +	term-gpios = <&gpio0 71 GPIO_ACTIVE_HIGH>;
>> +};
> you should really revisit the whole dts. Only PS part should be here and
> only stuff which have approved mainline dt binding.
Yes, some rework is necessary and will be done.
But i'm actually not the opinion that only the PS part should take place.
>> diff --git a/arch/arm/dts/zynq-brsmarc2_r512.dts b/arch/arm/dts/zynq-brsmarc2_r512.dts
>> new file mode 100644
>> index 0000000..44bfd14
>> --- /dev/null
>> +++ b/arch/arm/dts/zynq-brsmarc2_r512.dts
>> @@ -0,0 +1,16 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * B&R BRSMARC2 board base DTS file
>> + *
>> + *  Copyright (C) 2018 B&R Industrial Automation GmbH
>> + *
>> + */
>> +/dts-v1/;
>> +#include "zynq-brsmarc2.dtsi"
>> +
>> +/ {
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0x0 0x20000000>;
>> +	};
>> +};
>> diff --git a/board/BuR/zynq/.gitignore b/board/BuR/zynq/.gitignore
>> new file mode 100644
>> index 0000000..fa64fbc
>> --- /dev/null
>> +++ b/board/BuR/zynq/.gitignore
>> @@ -0,0 +1 @@
>> +./ps7_init_gpl.c
>> diff --git a/board/BuR/zynq/MAINTAINERS b/board/BuR/zynq/MAINTAINERS
>> new file mode 100644
>> index 0000000..c6b3cfb
>> --- /dev/null
>> +++ b/board/BuR/zynq/MAINTAINERS
>> @@ -0,0 +1,6 @@
>> +BRSMARC2 BOARD
>> +M:	Hannes Schmelzer <hannes.schmelzer at br-automation.com>
>> +S:	Maintained
>> +F:	board/BuR/zynq/
>> +F:	include/configs/brsmarc2.h
>> +F:	configs/brsmarc2_defconfig
>> diff --git a/board/BuR/zynq/Makefile b/board/BuR/zynq/Makefile
>> new file mode 100644
>> index 0000000..85a4b77
>> --- /dev/null
>> +++ b/board/BuR/zynq/Makefile
>> @@ -0,0 +1,16 @@
>> +# SPDX-License-Identifier: GPL-2.0+
>> +#
>> +# Copyright (C) 2019 Hannes Schmelzer <oe5hpm at oevsv.at> -
>> +# B&R Industrial Automation GmbH - http://www.br-automation.com
>> +#
>> +
>> +hw-platform-y :=$(shell echo $(CONFIG_DEFAULT_DEVICE_TREE) | sed -e 's/zynq-//')
>> +
>> +obj-y := ../common/common.o
>> +obj-y += ../common/br_resetc.o
>> +obj-y += $(hw-platform-y)/board.o
>> +
>> +obj-$(CONFIG_SPL_BUILD) += $(hw-platform-y)/ps7_init_gpl.o
>> +
>> +# Suppress "warning: function declaration isn't a prototype"
>> +CFLAGS_REMOVE_ps7_init_gpl.o := -Wstrict-prototypes
>> diff --git a/board/BuR/zynq/brsmarc2/board.c b/board/BuR/zynq/brsmarc2/board.c
>> new file mode 100644
>> index 0000000..b78b03a
>> --- /dev/null
>> +++ b/board/BuR/zynq/brsmarc2/board.c
>> @@ -0,0 +1,84 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * board.c
>> + *
>> + * Board functions for B&R BRSMARC2 Board
>> + *
>> + * Copyright (C) 2017 Hannes Schmelzer <oe5hpm at oevsv.at>
>> + * B&R Industrial Automation GmbH - http://www.br-automation.com
>> + *
>> + */
>> +#include <common.h>
>> +#include <fdtdec.h>
>> +#include <zynqpl.h>
>> +#include <asm/arch/hardware.h>
>> +#include <asm/arch/sys_proto.h>
>> +#include <asm/gpio.h>
>> +#include <i2c.h>
>> +#include "../../common/bur_common.h"
>> +#include "../../common/br_resetc.h"
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> +#ifdef CONFIG_SPL_BUILD
>> +int board_init(void)
>> +{
>> +	/* reset pulse for peripherals */
>> +	gpio_request(9, "nRESET_PS_3V3");
>> +	gpio_direction_output(9, 1);
>> +
>> +	return 0;
>> +}
>> +#else
>> +int board_init(void)
>> +{
>> +	return 0;
>> +}
>> +#endif
>> +
>> +int board_late_init(void)
>> +{
>> +	int rc;
>> +	struct udevice *i2cdev;
>> +
>> +	br_resetc_bmode();
>> +	brdefaultip_setup(0, 0x57);
>> +
>> +	rc = i2c_get_chip_for_busnum(0, 0x5D, 1, &i2cdev);
>> +	if (rc >= 0)
>> +		rc = dm_i2c_write(i2cdev, 0xEF, NULL, 0);
>> +	if (rc != 0)
>> +		printf("WARN: cannot write to LEDs!\n");
>> +
>> +	return 0;
>> +}
>> +
>> +int board_eth_init(bd_t *bis)
>> +{
>> +	return 0;
>> +}
> is this really used? With DM this should be gone.
I will drop this, this is maybe some leftover of the early days when i 
started the project.
>
>> +
>> +int dram_init(void)
>> +{
>> +	int node;
>> +	fdt_addr_t addr;
>> +	fdt_size_t size;
>> +	const void *blob = gd->fdt_blob;
>> +
>> +	node = fdt_node_offset_by_prop_value(blob, -1, "device_type",
>> +					     "memory", 7);
>> +	if (node == -FDT_ERR_NOTFOUND) {
>> +		debug("ZYNQ DRAM: Can't get memory node\n");
>> +		return -1;
>> +	}
>> +	addr = fdtdec_get_addr_size(blob, node, "reg", &size);
>> +	if (addr == FDT_ADDR_T_NONE || size == 0) {
>> +		debug("ZYNQ DRAM: Can't get base address or size\n");
>> +		return -1;
>> +	}
>> +	gd->ram_size = get_ram_size((void *)addr, size);
>> +
>> +	zynq_ddrc_init();
> This is just hybrid between DT/non DT case. Look at zynq boards and
> choose one.
> If you have two boards you can just use fixed case for 512MB version.
I will review this again and maybe dropping this in V3.
>
>> +
>> +	return 0;
>> +}
>> diff --git a/board/BuR/zynq/brsmarc2/ps7_init_gpl.c b/board/BuR/zynq/brsmarc2/ps7_init_gpl.c
>> new file mode 100644
>> index 0000000..a44c9d2
>> --- /dev/null
>> +++ b/board/BuR/zynq/brsmarc2/ps7_init_gpl.c
>> @@ -0,0 +1,814 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +#include <asm/arch/ps7_init_gpl.h>
>> +
>> +unsigned long ps7_pll_init_data_3_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000110, 0x003FFFF0U, 0x000FA220U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x0007F000U, 0x00028000U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000010U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000120, 0x1F003F30U, 0x1F000200U),
>> +	EMIT_MASKWRITE(0XF8000114, 0x003FFFF0U, 0x0012C220U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x0007F000U, 0x00020000U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000002U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000010U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000124, 0xFFF00003U, 0x0C200003U),
>> +	EMIT_MASKWRITE(0XF8000118, 0x003FFFF0U, 0x001452C0U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x0007F000U, 0x0001E000U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000004U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000010U, 0x00000000U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_clock_init_data_3_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000128, 0x03F03F01U, 0x00700F01U),
>> +	EMIT_MASKWRITE(0XF8000138, 0x00000011U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF800013C, 0x00000011U, 0x00000011U),
>> +	EMIT_MASKWRITE(0XF8000140, 0x03F03F71U, 0x00500801U),
>> +	EMIT_MASKWRITE(0XF8000144, 0x03F03F71U, 0x00500141U),
>> +	EMIT_MASKWRITE(0XF800014C, 0x00003F31U, 0x00000501U),
>> +	EMIT_MASKWRITE(0XF8000150, 0x00003F33U, 0x00000A01U),
>> +	EMIT_MASKWRITE(0XF8000154, 0x00003F33U, 0x00000A01U),
>> +	EMIT_MASKWRITE(0XF8000158, 0x00003F33U, 0x00000503U),
>> +	EMIT_MASKWRITE(0XF800015C, 0x03F03F33U, 0x00501903U),
>> +	EMIT_MASKWRITE(0XF8000160, 0x007F007FU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000168, 0x00003F31U, 0x00000501U),
>> +	EMIT_MASKWRITE(0XF8000170, 0x03F03F30U, 0x00400500U),
>> +	EMIT_MASKWRITE(0XF80001C4, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF800012C, 0x01FFCCCDU, 0x01DFC4CDU),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_ddr_init_data_3_0[] = {
>> +	EMIT_MASKWRITE(0XF8006000, 0x0001FFFFU, 0x00000080U),
>> +	EMIT_MASKWRITE(0XF8006004, 0x0007FFFFU, 0x00001040U),
>> +	EMIT_MASKWRITE(0XF8006008, 0x03FFFFFFU, 0x03C0780FU),
>> +	EMIT_MASKWRITE(0XF800600C, 0x03FFFFFFU, 0x02001001U),
>> +	EMIT_MASKWRITE(0XF8006010, 0x03FFFFFFU, 0x00014001U),
>> +	EMIT_MASKWRITE(0XF8006014, 0x001FFFFFU, 0x00040EDAU),
>> +	EMIT_MASKWRITE(0XF8006018, 0xF7FFFFFFU, 0x44D258D4U),
>> +	EMIT_MASKWRITE(0XF800601C, 0xFFFFFFFFU, 0xB2024127U),
>> +	EMIT_MASKWRITE(0XF8006020, 0x7FDFFFFCU, 0x2B08B290U),
>> +	EMIT_MASKWRITE(0XF8006024, 0x0FFFFFC3U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8006028, 0x00003FFFU, 0x00002007U),
>> +	EMIT_MASKWRITE(0XF800602C, 0xFFFFFFFFU, 0x00000018U),
>> +	EMIT_MASKWRITE(0XF8006030, 0xFFFFFFFFU, 0x00040970U),
>> +	EMIT_MASKWRITE(0XF8006034, 0x13FF3FFFU, 0x000116D4U),
>> +	EMIT_MASKWRITE(0XF8006038, 0x00000003U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF800603C, 0x000FFFFFU, 0x00000777U),
>> +	EMIT_MASKWRITE(0XF8006040, 0xFFFFFFFFU, 0xFFF00000U),
>> +	EMIT_MASKWRITE(0XF8006044, 0x0FFFFFFFU, 0x0FFF6666U),
>> +	EMIT_MASKWRITE(0XF8006048, 0x0003F03FU, 0x0003C008U),
>> +	EMIT_MASKWRITE(0XF8006050, 0xFF0F8FFFU, 0x77010800U),
>> +	EMIT_MASKWRITE(0XF8006058, 0x00010000U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF800605C, 0x0000FFFFU, 0x00005003U),
>> +	EMIT_MASKWRITE(0XF8006060, 0x000017FFU, 0x0000003EU),
>> +	EMIT_MASKWRITE(0XF8006064, 0x00021FE0U, 0x00020000U),
>> +	EMIT_MASKWRITE(0XF8006068, 0x03FFFFFFU, 0x00284545U),
>> +	EMIT_MASKWRITE(0XF800606C, 0x0000FFFFU, 0x00001610U),
>> +	EMIT_MASKWRITE(0XF8006078, 0x03FFFFFFU, 0x00466111U),
>> +	EMIT_MASKWRITE(0XF800607C, 0x000FFFFFU, 0x00032222U),
>> +	EMIT_MASKWRITE(0XF80060A4, 0xFFFFFFFFU, 0x10200802U),
>> +	EMIT_MASKWRITE(0XF80060A8, 0x0FFFFFFFU, 0x0690CB73U),
>> +	EMIT_MASKWRITE(0XF80060AC, 0x000001FFU, 0x000001FEU),
>> +	EMIT_MASKWRITE(0XF80060B0, 0x1FFFFFFFU, 0x1CFFFFFFU),
>> +	EMIT_MASKWRITE(0XF80060B4, 0x00000200U, 0x00000200U),
>> +	EMIT_MASKWRITE(0XF80060B8, 0x01FFFFFFU, 0x0020006AU),
>> +	EMIT_MASKWRITE(0XF80060C4, 0x00000003U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060C8, 0x000000FFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060DC, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060F0, 0x0000FFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060F4, 0x0000000FU, 0x00000008U),
>> +	EMIT_MASKWRITE(0XF8006114, 0x000000FFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8006118, 0x7FFFFFCFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF800611C, 0x7FFFFFCFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF8006120, 0x7FFFFFCFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF8006124, 0x7FFFFFCFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF800612C, 0x000FFFFFU, 0x0001D400U),
>> +	EMIT_MASKWRITE(0XF8006130, 0x000FFFFFU, 0x0001C400U),
>> +	EMIT_MASKWRITE(0XF8006134, 0x000FFFFFU, 0x0001BC00U),
>> +	EMIT_MASKWRITE(0XF8006138, 0x000FFFFFU, 0x0001C800U),
>> +	EMIT_MASKWRITE(0XF8006140, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006144, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006148, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF800614C, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006154, 0x000FFFFFU, 0x0000007AU),
>> +	EMIT_MASKWRITE(0XF8006158, 0x000FFFFFU, 0x0000007DU),
>> +	EMIT_MASKWRITE(0XF800615C, 0x000FFFFFU, 0x00000080U),
>> +	EMIT_MASKWRITE(0XF8006160, 0x000FFFFFU, 0x0000007EU),
>> +	EMIT_MASKWRITE(0XF8006168, 0x001FFFFFU, 0x000000CAU),
>> +	EMIT_MASKWRITE(0XF800616C, 0x001FFFFFU, 0x000000C6U),
>> +	EMIT_MASKWRITE(0XF8006170, 0x001FFFFFU, 0x000000C4U),
>> +	EMIT_MASKWRITE(0XF8006174, 0x001FFFFFU, 0x000000C7U),
>> +	EMIT_MASKWRITE(0XF800617C, 0x000FFFFFU, 0x000000BAU),
>> +	EMIT_MASKWRITE(0XF8006180, 0x000FFFFFU, 0x000000BDU),
>> +	EMIT_MASKWRITE(0XF8006184, 0x000FFFFFU, 0x000000C0U),
>> +	EMIT_MASKWRITE(0XF8006188, 0x000FFFFFU, 0x000000BEU),
>> +	EMIT_MASKWRITE(0XF8006190, 0x6FFFFEFEU, 0x00040080U),
>> +	EMIT_MASKWRITE(0XF8006194, 0x000FFFFFU, 0x0001FD04U),
>> +	EMIT_MASKWRITE(0XF8006204, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8006208, 0x000703FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF800620C, 0x000703FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006210, 0x000703FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006214, 0x000703FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006218, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF800621C, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006220, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006224, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF80062A8, 0x00000FF5U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80062AC, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80062B0, 0x003FFFFFU, 0x00005125U),
>> +	EMIT_MASKWRITE(0XF80062B4, 0x0003FFFFU, 0x000012A8U),
>> +	EMIT_MASKPOLL(0XF8000B74, 0x00002000U),
>> +	EMIT_MASKWRITE(0XF8006000, 0x0001FFFFU, 0x00000081U),
>> +	EMIT_MASKPOLL(0XF8006054, 0x00000007U),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_mio_init_data_3_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000B40, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B44, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B48, 0x00000FFFU, 0x00000672U),
>> +	EMIT_MASKWRITE(0XF8000B4C, 0x00000FFFU, 0x00000672U),
>> +	EMIT_MASKWRITE(0XF8000B50, 0x00000FFFU, 0x00000674U),
>> +	EMIT_MASKWRITE(0XF8000B54, 0x00000FFFU, 0x00000674U),
>> +	EMIT_MASKWRITE(0XF8000B58, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B5C, 0xFFFFFFFFU, 0x0018C068U),
>> +	EMIT_MASKWRITE(0XF8000B60, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B64, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B68, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B6C, 0x00007FFFU, 0x00000260U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x00000021U, 0x00000020U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x07FEFFFFU, 0x00000823U),
>> +	EMIT_MASKWRITE(0XF8000700, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000704, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000708, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF800070C, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000710, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000714, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000718, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF800071C, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000720, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000724, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000728, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF800072C, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000730, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000734, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000738, 0x00003FFFU, 0x000016E1U),
>> +	EMIT_MASKWRITE(0XF800073C, 0x00003FFFU, 0x000006E0U),
>> +	EMIT_MASKWRITE(0XF8000740, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000744, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000748, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF800074C, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000750, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000754, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000758, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF800075C, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000760, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000764, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000768, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF800076C, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000770, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000774, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000778, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800077C, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000780, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000784, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000788, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800078C, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000790, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000794, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000798, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800079C, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF80007A0, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007A4, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007A8, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007AC, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B0, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B4, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B8, 0x00003FFFU, 0x00000321U),
>> +	EMIT_MASKWRITE(0XF80007BC, 0x00003FFFU, 0x00000320U),
>> +	EMIT_MASKWRITE(0XF80007C0, 0x00003FFFU, 0x00000320U),
>> +	EMIT_MASKWRITE(0XF80007C4, 0x00003FFFU, 0x00000321U),
>> +	EMIT_MASKWRITE(0XF80007C8, 0x00003FFFU, 0x00000340U),
>> +	EMIT_MASKWRITE(0XF80007CC, 0x00003FFFU, 0x00000340U),
>> +	EMIT_MASKWRITE(0XF80007D0, 0x00003FFFU, 0x00000280U),
>> +	EMIT_MASKWRITE(0XF80007D4, 0x00003FFFU, 0x00000280U),
>> +	EMIT_MASKWRITE(0XF8000830, 0x003F003FU, 0x00380037U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_peripherals_init_data_3_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000B48, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B4C, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B50, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B54, 0x00000180U, 0x00000180U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_MASKWRITE(0XE0000034, 0x000000FFU, 0x00000006U),
>> +	EMIT_MASKWRITE(0XE0000018, 0x0000FFFFU, 0x0000007CU),
>> +	EMIT_MASKWRITE(0XE0000000, 0x000001FFU, 0x00000017U),
>> +	EMIT_MASKWRITE(0XE0000004, 0x000003FFU, 0x00000020U),
>> +	EMIT_MASKWRITE(0XE000D000, 0x00080000U, 0x00080000U),
>> +	EMIT_MASKWRITE(0XF8007000, 0x20000000U, 0x00000000U),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_post_config_3_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000900, 0x0000000FU, 0x0000000FU),
>> +	EMIT_MASKWRITE(0XF8000240, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_pll_init_data_2_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000110, 0x003FFFF0U, 0x000FA220U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x0007F000U, 0x00028000U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000010U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000120, 0x1F003F30U, 0x1F000200U),
>> +	EMIT_MASKWRITE(0XF8000114, 0x003FFFF0U, 0x0012C220U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x0007F000U, 0x00020000U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000002U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000010U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000124, 0xFFF00003U, 0x0C200003U),
>> +	EMIT_MASKWRITE(0XF8000118, 0x003FFFF0U, 0x001452C0U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x0007F000U, 0x0001E000U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000004U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000010U, 0x00000000U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_clock_init_data_2_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000128, 0x03F03F01U, 0x00700F01U),
>> +	EMIT_MASKWRITE(0XF8000138, 0x00000011U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF800013C, 0x00000011U, 0x00000011U),
>> +	EMIT_MASKWRITE(0XF8000140, 0x03F03F71U, 0x00500801U),
>> +	EMIT_MASKWRITE(0XF8000144, 0x03F03F71U, 0x00500141U),
>> +	EMIT_MASKWRITE(0XF800014C, 0x00003F31U, 0x00000501U),
>> +	EMIT_MASKWRITE(0XF8000150, 0x00003F33U, 0x00000A01U),
>> +	EMIT_MASKWRITE(0XF8000154, 0x00003F33U, 0x00000A01U),
>> +	EMIT_MASKWRITE(0XF8000158, 0x00003F33U, 0x00000503U),
>> +	EMIT_MASKWRITE(0XF800015C, 0x03F03F33U, 0x00501903U),
>> +	EMIT_MASKWRITE(0XF8000160, 0x007F007FU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000168, 0x00003F31U, 0x00000501U),
>> +	EMIT_MASKWRITE(0XF8000170, 0x03F03F30U, 0x00400500U),
>> +	EMIT_MASKWRITE(0XF80001C4, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF800012C, 0x01FFCCCDU, 0x01DFC4CDU),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_ddr_init_data_2_0[] = {
>> +	EMIT_MASKWRITE(0XF8006000, 0x0001FFFFU, 0x00000080U),
>> +	EMIT_MASKWRITE(0XF8006004, 0x1FFFFFFFU, 0x00081040U),
>> +	EMIT_MASKWRITE(0XF8006008, 0x03FFFFFFU, 0x03C0780FU),
>> +	EMIT_MASKWRITE(0XF800600C, 0x03FFFFFFU, 0x02001001U),
>> +	EMIT_MASKWRITE(0XF8006010, 0x03FFFFFFU, 0x00014001U),
>> +	EMIT_MASKWRITE(0XF8006014, 0x001FFFFFU, 0x00040EDAU),
>> +	EMIT_MASKWRITE(0XF8006018, 0xF7FFFFFFU, 0x44D258D4U),
>> +	EMIT_MASKWRITE(0XF800601C, 0xFFFFFFFFU, 0xB2024127U),
>> +	EMIT_MASKWRITE(0XF8006020, 0xFFFFFFFCU, 0x2B28B290U),
>> +	EMIT_MASKWRITE(0XF8006024, 0x0FFFFFFFU, 0x0000003CU),
>> +	EMIT_MASKWRITE(0XF8006028, 0x00003FFFU, 0x00002007U),
>> +	EMIT_MASKWRITE(0XF800602C, 0xFFFFFFFFU, 0x00000018U),
>> +	EMIT_MASKWRITE(0XF8006030, 0xFFFFFFFFU, 0x00040970U),
>> +	EMIT_MASKWRITE(0XF8006034, 0x13FF3FFFU, 0x000116D4U),
>> +	EMIT_MASKWRITE(0XF8006038, 0x00001FC3U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF800603C, 0x000FFFFFU, 0x00000777U),
>> +	EMIT_MASKWRITE(0XF8006040, 0xFFFFFFFFU, 0xFFF00000U),
>> +	EMIT_MASKWRITE(0XF8006044, 0x0FFFFFFFU, 0x0FFF6666U),
>> +	EMIT_MASKWRITE(0XF8006048, 0x3FFFFFFFU, 0x0003C248U),
>> +	EMIT_MASKWRITE(0XF8006050, 0xFF0F8FFFU, 0x77010800U),
>> +	EMIT_MASKWRITE(0XF8006058, 0x0001FFFFU, 0x00000101U),
>> +	EMIT_MASKWRITE(0XF800605C, 0x0000FFFFU, 0x00005003U),
>> +	EMIT_MASKWRITE(0XF8006060, 0x000017FFU, 0x0000003EU),
>> +	EMIT_MASKWRITE(0XF8006064, 0x00021FE0U, 0x00020000U),
>> +	EMIT_MASKWRITE(0XF8006068, 0x03FFFFFFU, 0x00284545U),
>> +	EMIT_MASKWRITE(0XF800606C, 0x0000FFFFU, 0x00001610U),
>> +	EMIT_MASKWRITE(0XF8006078, 0x03FFFFFFU, 0x00466111U),
>> +	EMIT_MASKWRITE(0XF800607C, 0x000FFFFFU, 0x00032222U),
>> +	EMIT_MASKWRITE(0XF80060A0, 0x00FFFFFFU, 0x00008000U),
>> +	EMIT_MASKWRITE(0XF80060A4, 0xFFFFFFFFU, 0x10200802U),
>> +	EMIT_MASKWRITE(0XF80060A8, 0x0FFFFFFFU, 0x0690CB73U),
>> +	EMIT_MASKWRITE(0XF80060AC, 0x000001FFU, 0x000001FEU),
>> +	EMIT_MASKWRITE(0XF80060B0, 0x1FFFFFFFU, 0x1CFFFFFFU),
>> +	EMIT_MASKWRITE(0XF80060B4, 0x000007FFU, 0x00000200U),
>> +	EMIT_MASKWRITE(0XF80060B8, 0x01FFFFFFU, 0x0020006AU),
>> +	EMIT_MASKWRITE(0XF80060C4, 0x00000003U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060C8, 0x000000FFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060DC, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060F0, 0x0000FFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060F4, 0x0000000FU, 0x00000008U),
>> +	EMIT_MASKWRITE(0XF8006114, 0x000000FFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8006118, 0x7FFFFFFFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF800611C, 0x7FFFFFFFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF8006120, 0x7FFFFFFFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF8006124, 0x7FFFFFFFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF800612C, 0x000FFFFFU, 0x0001D400U),
>> +	EMIT_MASKWRITE(0XF8006130, 0x000FFFFFU, 0x0001C400U),
>> +	EMIT_MASKWRITE(0XF8006134, 0x000FFFFFU, 0x0001BC00U),
>> +	EMIT_MASKWRITE(0XF8006138, 0x000FFFFFU, 0x0001C800U),
>> +	EMIT_MASKWRITE(0XF8006140, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006144, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006148, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF800614C, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006154, 0x000FFFFFU, 0x0000007AU),
>> +	EMIT_MASKWRITE(0XF8006158, 0x000FFFFFU, 0x0000007DU),
>> +	EMIT_MASKWRITE(0XF800615C, 0x000FFFFFU, 0x00000080U),
>> +	EMIT_MASKWRITE(0XF8006160, 0x000FFFFFU, 0x0000007EU),
>> +	EMIT_MASKWRITE(0XF8006168, 0x001FFFFFU, 0x000000CAU),
>> +	EMIT_MASKWRITE(0XF800616C, 0x001FFFFFU, 0x000000C6U),
>> +	EMIT_MASKWRITE(0XF8006170, 0x001FFFFFU, 0x000000C4U),
>> +	EMIT_MASKWRITE(0XF8006174, 0x001FFFFFU, 0x000000C7U),
>> +	EMIT_MASKWRITE(0XF800617C, 0x000FFFFFU, 0x000000BAU),
>> +	EMIT_MASKWRITE(0XF8006180, 0x000FFFFFU, 0x000000BDU),
>> +	EMIT_MASKWRITE(0XF8006184, 0x000FFFFFU, 0x000000C0U),
>> +	EMIT_MASKWRITE(0XF8006188, 0x000FFFFFU, 0x000000BEU),
>> +	EMIT_MASKWRITE(0XF8006190, 0xFFFFFFFFU, 0x10040080U),
>> +	EMIT_MASKWRITE(0XF8006194, 0x000FFFFFU, 0x0001FD04U),
>> +	EMIT_MASKWRITE(0XF8006204, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8006208, 0x000F03FFU, 0x000803FFU),
>> +	EMIT_MASKWRITE(0XF800620C, 0x000F03FFU, 0x000803FFU),
>> +	EMIT_MASKWRITE(0XF8006210, 0x000F03FFU, 0x000803FFU),
>> +	EMIT_MASKWRITE(0XF8006214, 0x000F03FFU, 0x000803FFU),
>> +	EMIT_MASKWRITE(0XF8006218, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF800621C, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006220, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006224, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF80062A8, 0x00000FF7U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80062AC, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80062B0, 0x003FFFFFU, 0x00005125U),
>> +	EMIT_MASKWRITE(0XF80062B4, 0x0003FFFFU, 0x000012A8U),
>> +	EMIT_MASKPOLL(0XF8000B74, 0x00002000U),
>> +	EMIT_MASKWRITE(0XF8006000, 0x0001FFFFU, 0x00000081U),
>> +	EMIT_MASKPOLL(0XF8006054, 0x00000007U),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_mio_init_data_2_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000B40, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B44, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B48, 0x00000FFFU, 0x00000672U),
>> +	EMIT_MASKWRITE(0XF8000B4C, 0x00000FFFU, 0x00000672U),
>> +	EMIT_MASKWRITE(0XF8000B50, 0x00000FFFU, 0x00000674U),
>> +	EMIT_MASKWRITE(0XF8000B54, 0x00000FFFU, 0x00000674U),
>> +	EMIT_MASKWRITE(0XF8000B58, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B5C, 0xFFFFFFFFU, 0x0018C068U),
>> +	EMIT_MASKWRITE(0XF8000B60, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B64, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B68, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B6C, 0x00007FFFU, 0x00000260U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x00000021U, 0x00000021U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x00000021U, 0x00000020U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x07FFFFFFU, 0x00000823U),
>> +	EMIT_MASKWRITE(0XF8000700, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000704, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000708, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF800070C, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000710, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000714, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000718, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF800071C, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000720, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000724, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000728, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF800072C, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000730, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000734, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000738, 0x00003FFFU, 0x000016E1U),
>> +	EMIT_MASKWRITE(0XF800073C, 0x00003FFFU, 0x000006E0U),
>> +	EMIT_MASKWRITE(0XF8000740, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000744, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000748, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF800074C, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000750, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000754, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000758, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF800075C, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000760, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000764, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000768, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF800076C, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000770, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000774, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000778, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800077C, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000780, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000784, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000788, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800078C, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000790, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000794, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000798, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800079C, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF80007A0, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007A4, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007A8, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007AC, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B0, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B4, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B8, 0x00003FFFU, 0x00000321U),
>> +	EMIT_MASKWRITE(0XF80007BC, 0x00003FFFU, 0x00000320U),
>> +	EMIT_MASKWRITE(0XF80007C0, 0x00003FFFU, 0x00000320U),
>> +	EMIT_MASKWRITE(0XF80007C4, 0x00003FFFU, 0x00000321U),
>> +	EMIT_MASKWRITE(0XF80007C8, 0x00003FFFU, 0x00000340U),
>> +	EMIT_MASKWRITE(0XF80007CC, 0x00003FFFU, 0x00000340U),
>> +	EMIT_MASKWRITE(0XF80007D0, 0x00003FFFU, 0x00000280U),
>> +	EMIT_MASKWRITE(0XF80007D4, 0x00003FFFU, 0x00000280U),
>> +	EMIT_MASKWRITE(0XF8000830, 0x003F003FU, 0x00380037U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_peripherals_init_data_2_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000B48, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B4C, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B50, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B54, 0x00000180U, 0x00000180U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_MASKWRITE(0XE0000034, 0x000000FFU, 0x00000006U),
>> +	EMIT_MASKWRITE(0XE0000018, 0x0000FFFFU, 0x0000007CU),
>> +	EMIT_MASKWRITE(0XE0000000, 0x000001FFU, 0x00000017U),
>> +	EMIT_MASKWRITE(0XE0000004, 0x00000FFFU, 0x00000020U),
>> +	EMIT_MASKWRITE(0XE000D000, 0x00080000U, 0x00080000U),
>> +	EMIT_MASKWRITE(0XF8007000, 0x20000000U, 0x00000000U),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_EXIT(),
>> +
>> +};
>> +
>> +unsigned long ps7_post_config_2_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000900, 0x0000000FU, 0x0000000FU),
>> +	EMIT_MASKWRITE(0XF8000240, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_pll_init_data_1_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000110, 0x003FFFF0U, 0x000FA220U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x0007F000U, 0x00028000U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000100, 0x00000010U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000120, 0x1F003F30U, 0x1F000200U),
>> +	EMIT_MASKWRITE(0XF8000114, 0x003FFFF0U, 0x0012C220U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x0007F000U, 0x00020000U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000002U),
>> +	EMIT_MASKWRITE(0XF8000104, 0x00000010U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000124, 0xFFF00003U, 0x0C200003U),
>> +	EMIT_MASKWRITE(0XF8000118, 0x003FFFF0U, 0x001452C0U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x0007F000U, 0x0001E000U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000010U, 0x00000010U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKPOLL(0XF800010C, 0x00000004U),
>> +	EMIT_MASKWRITE(0XF8000108, 0x00000010U, 0x00000000U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_clock_init_data_1_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000128, 0x03F03F01U, 0x00700F01U),
>> +	EMIT_MASKWRITE(0XF8000138, 0x00000011U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF800013C, 0x00000011U, 0x00000011U),
>> +	EMIT_MASKWRITE(0XF8000140, 0x03F03F71U, 0x00500801U),
>> +	EMIT_MASKWRITE(0XF8000144, 0x03F03F71U, 0x00500141U),
>> +	EMIT_MASKWRITE(0XF800014C, 0x00003F31U, 0x00000501U),
>> +	EMIT_MASKWRITE(0XF8000150, 0x00003F33U, 0x00000A01U),
>> +	EMIT_MASKWRITE(0XF8000154, 0x00003F33U, 0x00000A01U),
>> +	EMIT_MASKWRITE(0XF8000158, 0x00003F33U, 0x00000503U),
>> +	EMIT_MASKWRITE(0XF800015C, 0x03F03F33U, 0x00501903U),
>> +	EMIT_MASKWRITE(0XF8000160, 0x007F007FU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8000168, 0x00003F31U, 0x00000501U),
>> +	EMIT_MASKWRITE(0XF8000170, 0x03F03F30U, 0x00400500U),
>> +	EMIT_MASKWRITE(0XF80001C4, 0x00000001U, 0x00000001U),
>> +	EMIT_MASKWRITE(0XF800012C, 0x01FFCCCDU, 0x01DFC4CDU),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_ddr_init_data_1_0[] = {
>> +	EMIT_MASKWRITE(0XF8006000, 0x0001FFFFU, 0x00000080U),
>> +	EMIT_MASKWRITE(0XF8006004, 0x1FFFFFFFU, 0x00081040U),
>> +	EMIT_MASKWRITE(0XF8006008, 0x03FFFFFFU, 0x03C0780FU),
>> +	EMIT_MASKWRITE(0XF800600C, 0x03FFFFFFU, 0x02001001U),
>> +	EMIT_MASKWRITE(0XF8006010, 0x03FFFFFFU, 0x00014001U),
>> +	EMIT_MASKWRITE(0XF8006014, 0x001FFFFFU, 0x00040EDAU),
>> +	EMIT_MASKWRITE(0XF8006018, 0xF7FFFFFFU, 0x44D258D4U),
>> +	EMIT_MASKWRITE(0XF800601C, 0xFFFFFFFFU, 0xB2024127U),
>> +	EMIT_MASKWRITE(0XF8006020, 0xFFFFFFFCU, 0x2B28B290U),
>> +	EMIT_MASKWRITE(0XF8006024, 0x0FFFFFFFU, 0x0000003CU),
>> +	EMIT_MASKWRITE(0XF8006028, 0x00003FFFU, 0x00002007U),
>> +	EMIT_MASKWRITE(0XF800602C, 0xFFFFFFFFU, 0x00000018U),
>> +	EMIT_MASKWRITE(0XF8006030, 0xFFFFFFFFU, 0x00040970U),
>> +	EMIT_MASKWRITE(0XF8006034, 0x13FF3FFFU, 0x000116D4U),
>> +	EMIT_MASKWRITE(0XF8006038, 0x00001FC3U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF800603C, 0x000FFFFFU, 0x00000777U),
>> +	EMIT_MASKWRITE(0XF8006040, 0xFFFFFFFFU, 0xFFF00000U),
>> +	EMIT_MASKWRITE(0XF8006044, 0x0FFFFFFFU, 0x0FFF6666U),
>> +	EMIT_MASKWRITE(0XF8006048, 0x3FFFFFFFU, 0x0003C248U),
>> +	EMIT_MASKWRITE(0XF8006050, 0xFF0F8FFFU, 0x77010800U),
>> +	EMIT_MASKWRITE(0XF8006058, 0x0001FFFFU, 0x00000101U),
>> +	EMIT_MASKWRITE(0XF800605C, 0x0000FFFFU, 0x00005003U),
>> +	EMIT_MASKWRITE(0XF8006060, 0x000017FFU, 0x0000003EU),
>> +	EMIT_MASKWRITE(0XF8006064, 0x00021FE0U, 0x00020000U),
>> +	EMIT_MASKWRITE(0XF8006068, 0x03FFFFFFU, 0x00284545U),
>> +	EMIT_MASKWRITE(0XF800606C, 0x0000FFFFU, 0x00001610U),
>> +	EMIT_MASKWRITE(0XF80060A0, 0x00FFFFFFU, 0x00008000U),
>> +	EMIT_MASKWRITE(0XF80060A4, 0xFFFFFFFFU, 0x10200802U),
>> +	EMIT_MASKWRITE(0XF80060A8, 0x0FFFFFFFU, 0x0690CB73U),
>> +	EMIT_MASKWRITE(0XF80060AC, 0x000001FFU, 0x000001FEU),
>> +	EMIT_MASKWRITE(0XF80060B0, 0x1FFFFFFFU, 0x1CFFFFFFU),
>> +	EMIT_MASKWRITE(0XF80060B4, 0x000007FFU, 0x00000200U),
>> +	EMIT_MASKWRITE(0XF80060B8, 0x01FFFFFFU, 0x0020006AU),
>> +	EMIT_MASKWRITE(0XF80060C4, 0x00000003U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060C8, 0x000000FFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060DC, 0x00000001U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060F0, 0x0000FFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80060F4, 0x0000000FU, 0x00000008U),
>> +	EMIT_MASKWRITE(0XF8006114, 0x000000FFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8006118, 0x7FFFFFFFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF800611C, 0x7FFFFFFFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF8006120, 0x7FFFFFFFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF8006124, 0x7FFFFFFFU, 0x40000001U),
>> +	EMIT_MASKWRITE(0XF800612C, 0x000FFFFFU, 0x0001D400U),
>> +	EMIT_MASKWRITE(0XF8006130, 0x000FFFFFU, 0x0001C400U),
>> +	EMIT_MASKWRITE(0XF8006134, 0x000FFFFFU, 0x0001BC00U),
>> +	EMIT_MASKWRITE(0XF8006138, 0x000FFFFFU, 0x0001C800U),
>> +	EMIT_MASKWRITE(0XF8006140, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006144, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006148, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF800614C, 0x000FFFFFU, 0x00000035U),
>> +	EMIT_MASKWRITE(0XF8006154, 0x000FFFFFU, 0x0000007AU),
>> +	EMIT_MASKWRITE(0XF8006158, 0x000FFFFFU, 0x0000007DU),
>> +	EMIT_MASKWRITE(0XF800615C, 0x000FFFFFU, 0x00000080U),
>> +	EMIT_MASKWRITE(0XF8006160, 0x000FFFFFU, 0x0000007EU),
>> +	EMIT_MASKWRITE(0XF8006168, 0x001FFFFFU, 0x000000CAU),
>> +	EMIT_MASKWRITE(0XF800616C, 0x001FFFFFU, 0x000000C6U),
>> +	EMIT_MASKWRITE(0XF8006170, 0x001FFFFFU, 0x000000C4U),
>> +	EMIT_MASKWRITE(0XF8006174, 0x001FFFFFU, 0x000000C7U),
>> +	EMIT_MASKWRITE(0XF800617C, 0x000FFFFFU, 0x000000BAU),
>> +	EMIT_MASKWRITE(0XF8006180, 0x000FFFFFU, 0x000000BDU),
>> +	EMIT_MASKWRITE(0XF8006184, 0x000FFFFFU, 0x000000C0U),
>> +	EMIT_MASKWRITE(0XF8006188, 0x000FFFFFU, 0x000000BEU),
>> +	EMIT_MASKWRITE(0XF8006190, 0xFFFFFFFFU, 0x10040080U),
>> +	EMIT_MASKWRITE(0XF8006194, 0x000FFFFFU, 0x0001FD04U),
>> +	EMIT_MASKWRITE(0XF8006204, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF8006208, 0x000F03FFU, 0x000803FFU),
>> +	EMIT_MASKWRITE(0XF800620C, 0x000F03FFU, 0x000803FFU),
>> +	EMIT_MASKWRITE(0XF8006210, 0x000F03FFU, 0x000803FFU),
>> +	EMIT_MASKWRITE(0XF8006214, 0x000F03FFU, 0x000803FFU),
>> +	EMIT_MASKWRITE(0XF8006218, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF800621C, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006220, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF8006224, 0x000F03FFU, 0x000003FFU),
>> +	EMIT_MASKWRITE(0XF80062A8, 0x00000FF7U, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80062AC, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_MASKWRITE(0XF80062B0, 0x003FFFFFU, 0x00005125U),
>> +	EMIT_MASKWRITE(0XF80062B4, 0x0003FFFFU, 0x000012A8U),
>> +	EMIT_MASKPOLL(0XF8000B74, 0x00002000U),
>> +	EMIT_MASKWRITE(0XF8006000, 0x0001FFFFU, 0x00000081U),
>> +	EMIT_MASKPOLL(0XF8006054, 0x00000007U),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_mio_init_data_1_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000B40, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B44, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B48, 0x00000FFFU, 0x00000672U),
>> +	EMIT_MASKWRITE(0XF8000B4C, 0x00000FFFU, 0x00000672U),
>> +	EMIT_MASKWRITE(0XF8000B50, 0x00000FFFU, 0x00000674U),
>> +	EMIT_MASKWRITE(0XF8000B54, 0x00000FFFU, 0x00000674U),
>> +	EMIT_MASKWRITE(0XF8000B58, 0x00000FFFU, 0x00000600U),
>> +	EMIT_MASKWRITE(0XF8000B5C, 0xFFFFFFFFU, 0x0018C068U),
>> +	EMIT_MASKWRITE(0XF8000B60, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B64, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B68, 0xFFFFFFFFU, 0x00F98068U),
>> +	EMIT_MASKWRITE(0XF8000B6C, 0x000073FFU, 0x00000260U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x00000021U, 0x00000021U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x00000021U, 0x00000020U),
>> +	EMIT_MASKWRITE(0XF8000B70, 0x07FFFFFFU, 0x00000823U),
>> +	EMIT_MASKWRITE(0XF8000700, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000704, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000708, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF800070C, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000710, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000714, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000718, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF800071C, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000720, 0x00003FFFU, 0x00000702U),
>> +	EMIT_MASKWRITE(0XF8000724, 0x00003FFFU, 0x00000700U),
>> +	EMIT_MASKWRITE(0XF8000728, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF800072C, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000730, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000734, 0x00003FFFU, 0x000007A0U),
>> +	EMIT_MASKWRITE(0XF8000738, 0x00003FFFU, 0x000016E1U),
>> +	EMIT_MASKWRITE(0XF800073C, 0x00003FFFU, 0x000006E0U),
>> +	EMIT_MASKWRITE(0XF8000740, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000744, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000748, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF800074C, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000750, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000754, 0x00003FFFU, 0x00000302U),
>> +	EMIT_MASKWRITE(0XF8000758, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF800075C, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000760, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000764, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000768, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF800076C, 0x00003FFFU, 0x00000303U),
>> +	EMIT_MASKWRITE(0XF8000770, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000774, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000778, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800077C, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000780, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000784, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000788, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800078C, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000790, 0x00003FFFU, 0x00000205U),
>> +	EMIT_MASKWRITE(0XF8000794, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF8000798, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF800079C, 0x00003FFFU, 0x00000204U),
>> +	EMIT_MASKWRITE(0XF80007A0, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007A4, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007A8, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007AC, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B0, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B4, 0x00003FFFU, 0x00000380U),
>> +	EMIT_MASKWRITE(0XF80007B8, 0x00003FFFU, 0x00000321U),
>> +	EMIT_MASKWRITE(0XF80007BC, 0x00003FFFU, 0x00000320U),
>> +	EMIT_MASKWRITE(0XF80007C0, 0x00003FFFU, 0x00000320U),
>> +	EMIT_MASKWRITE(0XF80007C4, 0x00003FFFU, 0x00000321U),
>> +	EMIT_MASKWRITE(0XF80007C8, 0x00003FFFU, 0x00000340U),
>> +	EMIT_MASKWRITE(0XF80007CC, 0x00003FFFU, 0x00000340U),
>> +	EMIT_MASKWRITE(0XF80007D0, 0x00003FFFU, 0x00000280U),
>> +	EMIT_MASKWRITE(0XF80007D4, 0x00003FFFU, 0x00000280U),
>> +	EMIT_MASKWRITE(0XF8000830, 0x003F003FU, 0x00380037U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_peripherals_init_data_1_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000B48, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B4C, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B50, 0x00000180U, 0x00000180U),
>> +	EMIT_MASKWRITE(0XF8000B54, 0x00000180U, 0x00000180U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_MASKWRITE(0XE0000034, 0x000000FFU, 0x00000006U),
>> +	EMIT_MASKWRITE(0XE0000018, 0x0000FFFFU, 0x0000007CU),
>> +	EMIT_MASKWRITE(0XE0000000, 0x000001FFU, 0x00000017U),
>> +	EMIT_MASKWRITE(0XE0000004, 0x00000FFFU, 0x00000020U),
>> +	EMIT_MASKWRITE(0XE000D000, 0x00080000U, 0x00080000U),
>> +	EMIT_MASKWRITE(0XF8007000, 0x20000000U, 0x00000000U),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_MASKDELAY(0XF8F00200, 1),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long ps7_post_config_1_0[] = {
>> +	EMIT_WRITE(0XF8000008, 0x0000DF0DU),
>> +	EMIT_MASKWRITE(0XF8000900, 0x0000000FU, 0x0000000FU),
>> +	EMIT_MASKWRITE(0XF8000240, 0xFFFFFFFFU, 0x00000000U),
>> +	EMIT_WRITE(0XF8000004, 0x0000767BU),
>> +	EMIT_EXIT(),
>> +};
>> +
>> +unsigned long get_ps7_siliconversion(void)
>> +{
>> +	unsigned long mask = 0xF0000000;
>> +	unsigned long *addr = (unsigned long *)0XF8007080;
>> +	unsigned long ps_version = (*addr & mask) >> 28;
>> +
>> +	return ps_version;
>> +}
>> +
>> +unsigned long *ps7_mio_init_data = ps7_mio_init_data_3_0;
>> +unsigned long *ps7_pll_init_data = ps7_pll_init_data_3_0;
>> +unsigned long *ps7_clock_init_data = ps7_clock_init_data_3_0;
>> +unsigned long *ps7_ddr_init_data = ps7_ddr_init_data_3_0;
>> +unsigned long *ps7_peripherals_init_data = ps7_peripherals_init_data_3_0;
>> +
>> +int ps7_post_config(void)
>> +{
>> +	unsigned long si_ver = get_ps7_siliconversion();
>> +	int ret = -1;
>> +
>> +	if (si_ver == PCW_SILICON_VERSION_1) {
>> +		ret = ps7_config(ps7_post_config_1_0);
>> +		if (ret != PS7_INIT_SUCCESS)
>> +			return ret;
>> +	} else if (si_ver == PCW_SILICON_VERSION_2) {
>> +		ret = ps7_config(ps7_post_config_2_0);
>> +		if (ret != PS7_INIT_SUCCESS)
>> +			return ret;
> I don't think you are using v1 silicon and I would be very very
> surprised if you use v2 silicon also.
> This should be production silicon that's why just keep stuff for v3 only.
Fine ... i will drop the older silicon version.
Maybe also Xilinx could eliminate those output in vivado.
> diff --git a/board/BuR/zynq/config.mk b/board/BuR/zynq/config.mk
>> new file mode 100644
>> index 0000000..17e3d57
>> --- /dev/null
>> +++ b/board/BuR/zynq/config.mk
>> @@ -0,0 +1,49 @@
>> +# SPDX-License-Identifier:	GPL-2.0+
>> +#
>> +# Copyright (C) 2019 Hannes Schmelzer <oe5hpm at oevsv.at> -
>> +# B&R Industrial Automation GmbH - http://www.br-automation.com
>> +#
>> +
>> +hw-platform-y :=$(shell echo $(CONFIG_DEFAULT_DEVICE_TREE) | sed -e 's/zynq-//')
>> +
>> +payload_off :=$(shell printf "%d" $(CONFIG_SYS_SPI_U_BOOT_OFFS))
>> +
>> +fpga_path := $(shell echo $(KBUILD_SRC)/board/$(BOARDDIR)/$(hw-platform-y))
>> +fpga_src  := $(shell ls $(fpga_path)/*.bit 2>/dev/null)
>> +fpga_file := $(shell echo $(fpga_src) | rev | cut -d/ -f1 | rev)
>> +fpga_off  := $(shell printf "%d" \
>> +	     $(shell cat $(fpga_path)/${fpga_file}.offset 2>/dev/null))
>> +flen_min  := $(shell expr ${payload_off} + ${fpga_off})
>> +
>> +quiet_cmd_prodbin = PRODBIN $@ $(payload_off)
>> +cmd_prodbin = \
>> +	dd if=/dev/zero bs=1 count=${flen_min} 2>/dev/null | tr "\000" "\377" >$@ && \
>> +	dd conv=notrunc bs=1 if=spl/boot.bin of=$@ seek=0 2>/dev/null && \
>> +	test -z ${fpga_src} && dd conv=notrunc bs=1 if=u-boot-dtb.img of=$@ seek=$(payload_off) 2>/dev/null && \
>> +	test -z ${fpga_src} || ( \
>> +		dd conv=notrunc bs=1 if=u-boot-dtb.img of=$@ seek=$(payload_off) 2>/dev/null; \
>> +		dd obs=1 if=$(fpga_file) of=$@ seek=$(fpga_off) 2>/dev/null \
>> +		)
>> +
>> +quiet_cmd_prodzip = SAPZIP  $@
>> +cmd_prodzip =					\
>> +	test -d misc && rm -r misc;		\
>> +	mkdir misc &&				\
>> +	cp spl/boot.bin misc/ &&		\
>> +	cp u-boot-dtb.img misc/ &&		\
>> +	zip -9 -r $@ misc/* >/dev/null $<
>> +
>> +quiet_cmd_fpga = FPGA    $@ ($(fpga_file)) @ $(fpga_off)
>> +cmd_fpga = test -z ${fpga_src} || cp ${fpga_src} $(fpga_file)
> What's the purpose of this code?
> What's your boot mode?
>
> There shouldn't be a need to do these hacks. Just let SPL load fit with
> bitstream in it. SPL will load it for you without any hack.
The main purpose is to generate at this place a 'production-binary', a 
binary which can be flashed into the QSPI during series production.
Goal is, as often as possible, having here a very small binary - because 
flashing QSPI during production is time intensive and therefore
expensive. It is much cheaper burning this flash out of a real OS which 
can drive full speed and quad mode.

Most of the time at no FPGA stuff is needed to bring up the system to a 
point where it can access ethernet and boot some vxWorks from there,
from where several other stuff is (even the FPGA bitstream) loaded and 
burnt into QSPI.
Also there exist cases, where the bitstream isn't within QSPI at all and 
always downloaded with DMA to the PL during runtime and the other extreme
is that bitstream must be already programmed into flash because ethernet 
relies on the FPGA stuff.

>> +
>> +$(hw-platform-y)_fpga:
>> +	$(call if_changed,fpga)
>> +
>> +$(hw-platform-y)_prog.bin: u-boot-dtb.img spl/boot.bin $(hw-platform-y)_fpga
>> +	$(call if_changed,prodbin)
>> +
>> +$(hw-platform-y)_prod.zip: $(hw-platform-y)_prog.bin
>> +	$(call if_changed,prodzip)
>> +
>> +
>> +ALL-y += $(hw-platform-y)_prod.zip
>> diff --git a/board/BuR/zynq/take_vivadoHandoff.sh b/board/BuR/zynq/take_vivadoHandoff.sh
>> new file mode 100755
>> index 0000000..227c0f7
>> --- /dev/null
>> +++ b/board/BuR/zynq/take_vivadoHandoff.sh
>> @@ -0,0 +1,36 @@
>> +#!/bin/bash
>> +# SPDX-License-Identifier: GPL-2.0+
>> +FILE=ps7_init_gpl.c
>> +
>> +# remove DOS line-endings
>> +sed -i "s/^M//" $FILE
>> +# uncrustify
>> +uncrustify -c ./uncrustify.cfg --no-backup $FILE
>> +# strip trailing white space
>> +sed -i 's/[[:space:]]*$//' $FILE
>> +# fix identation
>> +indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1 -il0 $FILE
>> +
>> +# fix leftover comments
>> +sed -i '/xil_printf/d' $FILE
>> +# drop comments on register accesses
>> +sed -i '/*\*/d' $FILE
>> +sed -i '/ \*/d' $FILE
>> +sed -i '/* ../d' $FILE
>> +# use common header files
>> +sed -i\
>> + 's/#include \"ps7_init_gpl.h\"/#include <asm\/arch\/ps7_init_gpl.h>/g' $FILE
>> +# insert SPDX license identifier
>> +sed -i '1s/^/\/\/ SPDX-License-Identifier: GPL-2.0+\n/' $FILE
>> +
>> +pushd ../../../
>> +echo "######## running checkpatch script ..."
>> +scripts/checkpatch.pl\
>> + -f board/BuR/zynq/$FILE --fix-inplace
>> +
>> +echo "######## running checkpatch script (again) ..."
>> +scripts/checkpatch.pl\
>> + -f board/BuR/zynq/$FILE --fix-inplace
>> +
>> +popd
>> +rm $FILE~
> :-) we should put this to xilinx folder. IIRC I was sending these steps
> long time ago to ML but never had time to clean it up.
> Anyway some documentation what this is for will be useful.
Good idea,
so just for clarify: drop it from this patch and clean it up a bit and 
create a new patch for having it within xilinx?
>
>> diff --git a/board/BuR/zynq/uncrustify.cfg b/board/BuR/zynq/uncrustify.cfg
>> new file mode 100644
>> index 0000000..c5370f1
>> --- /dev/null
>> +++ b/board/BuR/zynq/uncrustify.cfg
>> @@ -0,0 +1,91 @@
>> +#
>> +# uncrustify config file for the linux kernel
>> +#
>> +# http://uncrustify.sourceforge.net/config.txt
>> +
>> +indent_with_tabs	= 2		# 1=indent to level only, 2=indent with tabs
>> +input_tab_size		= 8		# original tab size
>> +output_tab_size		= 8		# new tab size
>> +indent_columns		= output_tab_size
>> +
>> +indent_label		= 1		# pos: absolute col, neg: relative column
>> +
>> +
>> +#
>> +# inter-symbol newlines
>> +#
>> +
>> +nl_enum_brace		= remove	# "enum {" vs "enum \n {"
>> +nl_union_brace		= remove	# "union {" vs "union \n {"
>> +nl_struct_brace		= remove	# "struct {" vs "struct \n {"
>> +nl_do_brace		= remove	# "do {" vs "do \n {"
>> +nl_if_brace		= remove	# "if () {" vs "if () \n {"
>> +nl_for_brace		= remove	# "for () {" vs "for () \n {"
>> +nl_else_brace		= remove	# "else {" vs "else \n {"
>> +nl_while_brace		= remove	# "while () {" vs "while () \n {"
>> +nl_switch_brace		= remove	# "switch () {" vs "switch () \n {"
>> +nl_brace_while		= remove	# "} while" vs "} \n while" - cuddle while
>> +nl_brace_else		= remove	# "} else" vs "} \n else" - cuddle else
>> +nl_func_var_def_blk	= 1
>> +nl_fcall_brace		= remove	# "list_for_each() {" vs "list_for_each()\n{"
>> +nl_fdef_brace		= add		# "int foo() {" vs "int foo()\n{"
>> +# nl_after_return	= TRUE;
>> +# nl_before_case	= 1
>> +
>> +#
>> +# Source code modifications
>> +#
>> +
>> +mod_paren_on_return	= remove	# "return 1;" vs "return (1);"
>> +mod_full_brace_if	= remove	# "if (a) a--;" vs "if (a) { a--; }"
>> +mod_full_brace_for	= remove	# "for () a--;" vs "for () { a--; }"
>> +mod_full_brace_do	= remove	# "do a--; while ();" vs "do { a--; } while ();"
>> +mod_full_brace_while	= remove	# "while (a) a--;" vs "while (a) { a--; }"
>> +mod_full_brace_nl	= 3		# don't remove if more than 3 newlines
>> +
>> +
>> +#
>> +# inter-character spacing options
>> +#
>> +
>> +# sp_return_paren	= force		# "return (1);" vs "return(1);"
>> +sp_sizeof_paren		= remove	# "sizeof (int)" vs "sizeof(int)"
>> +sp_before_sparen	= force		# "if (" vs "if("
>> +sp_after_sparen		= force		# "if () {" vs "if (){"
>> +sp_after_cast		= remove	# "(int) a" vs "(int)a"
>> +sp_inside_braces	= add		# "{ 1 }" vs "{1}"
>> +sp_inside_braces_struct	= add		# "{ 1 }" vs "{1}"
>> +sp_inside_braces_enum	= add		# "{ 1 }" vs "{1}"
>> +sp_assign		= add
>> +sp_arith		= add
>> +sp_bool			= add
>> +sp_compare		= add
>> +sp_assign		= add
>> +sp_after_comma		= add
>> +sp_func_def_paren	= remove	# "int foo (){" vs "int foo(){"
>> +sp_func_call_paren	= remove	# "foo (" vs "foo("
>> +sp_func_proto_paren	= remove	# "int foo ();" vs "int foo();"
>> +
>> +#
>> +# Aligning stuff
>> +#
>> +align_with_tabs		= TRUE		# use tabs to align
>> +align_on_tabstop	= TRUE		# align on tabstops
>> +# align_keep_tabs	= true
>> +align_enum_equ_span	= 4		# '=' in enum definition
>> +# align_nl_cont		= TRUE
>> +# align_var_def_span	= 2
>> +# align_var_def_inline	= TRUE
>> +# align_var_def_star	= FALSE
>> +# align_var_def_colon	= TRUE
>> +# align_assign_span	= 1
>> +align_struct_init_span	= 3		# align stuff in a structure init '= { }'
>> +align_right_cmt_span	= 3
>> +# align_pp_define_span	= 8;
>> +# align_pp_define_gap	= 4;
>> +
>> +# cmt_star_cont		= FALSE
>> +
>> +# indent_brace		= 0
>> +
>> +cmt_cpp_to_c		= TRUE
should this walk into xilinx folder too?

(....)
>> diff --git a/include/configs/brsmarc2.h b/include/configs/brsmarc2.h
>> new file mode 100644
>> index 0000000..fc8968c
>> --- /dev/null
>> +++ b/include/configs/brsmarc2.h
>> @@ -0,0 +1,166 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>> +/*
>> + * specific parts for B&R X20CP Motherboard
>> + *
>> + * Copyright (C) 2016 Hannes Schmelzer <oe5hpm at oevsv.at> -
>> + * B&R Industrial Automation GmbH - http://www.br-automation.com
>> + *
>> + */
>> +
>> +#ifndef __CONFIG_BRSMARC2_H__
>> +#define __CONFIG_BRSMARC2_H__
>> +
>> +#include <configs/bur_cfg_common.h>
>
> you should be able to source zynq-7000.h and just change stuff what are
> missing there or you want to change.
i need some default environment from the bur_cfg_common.
Also i don't really like to use the zynq-7000.h, because i want to stay
here independent of some global configuration.
Long days ago i did choose same strategy on my am335x boards,
it showed up that this was the right way.
>
>> +
>> +/* Cache options */
>> +#define CONFIG_SYS_L2CACHE_OFF
>> +#ifndef CONFIG_SYS_L2CACHE_OFF
>> +# define CONFIG_SYS_L2_PL310
>> +# define CONFIG_SYS_PL310_BASE		0xf8f02000
>> +#endif
>> +
>> +#define ZYNQ_SCUTIMER_BASEADDR		0xF8F00600
>> +#define CONFIG_SYS_TIMERBASE		ZYNQ_SCUTIMER_BASEADDR
>> +#define CONFIG_SYS_TIMER_COUNTS_DOWN
>> +#define CONFIG_SYS_TIMER_COUNTER	(CONFIG_SYS_TIMERBASE + 0x4)
>> +
>> +/* Serial drivers */
>> +#define CONFIG_BAUDRATE		115200
>> +/* The following table includes the supported baudrates */
>> +#define CONFIG_SYS_BAUDRATE_TABLE  \
>> +	{300, 600, 1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200, 230400}
>> +#define CONFIG_ZYNQ_SERIAL
>> +
>> +/* Ethernet driver */
>> +#ifdef CONFIG_ZYNQ_GEM
>> +# define CONFIG_MII
>> +# define CONFIG_BOOTP_MAY_FAIL
>> +#endif
>> +
>> +/* MMC */
>> +#define CONFIG_ZYNQ_HISPD_BROKEN
>> +
>> +#define CONFIG_EHCI_IS_TDI
>> +#define CONFIG_USB_MAX_CONTROLLER_COUNT	1
> please check if these can't be setup via Kconfig.
> If not feel free to move it to Kconfig first.
I will do so in v3.

>
>> +/* Allow to overwrite serial and ethaddr */
>> +#define CONFIG_ENV_OVERWRITE
>> +
>> +/* Environment */
>> +#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
>> +#define CONFIG_ENV_SPI_MAX_HZ			CONFIG_SF_DEFAULT_SPEED
>> +#define CONFIG_ENV_OFFSET_REDUND		(CONFIG_ENV_OFFSET + \
>> +						 CONFIG_ENV_SECT_SIZE)
>> +#define CONFIG_EXTRA_ENV_SETTINGS	\
>> +BUR_COMMON_ENV \
>> +"board_id=0xFF\0" \
>> +"autoload=0\0" \
> weird.
Can you explain me more ?
>
>> +"scradr=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \
>> +"dtbaddr=0x4000000\0" \
>> +"loadaddr=0x2000000\0" \
>> +"fpgaaddr=fdt get value fpgabase /fpga bur,updaddr;" \
>> +" fdt get value fpgasize /fpga bur,updsize\0" \
>> +"fpga=setenv fpgastatus disabled; run fpgaaddr;" \
>> +" sf read ${loadaddr} ${fpgabase} ${fpgasize} &&" \
>> +" fpga loadb 0 ${loadaddr} ${fpgasize} && setenv fpgastatus okay\0" \
>> +"fpgastatus=disabled\0" \
>> +"fpgaupd=run fpgaaddr && tftp ${loadaddr} X20CP04xx.bit &&" \
>> +" sf erase ${fpgabase} +${filesize} &&" \
>> +" sf write ${loadaddr} ${fpgabase} ${filesize}\0" \
>> +"netupd=tftp ${loadaddr} boot.bin && sf probe &&" \
>> +" sf erase 0 +${filesize} && sf write ${loadaddr} 0 ${filesize} &&" \
>> +" tftp ${loadaddr} u-boot-dtb.img &&" \
>> +" sf erase 0x40000 +${filesize} && sf write ${loadaddr} 0x40000 ${filesize}\0" \
>> +"cfgscr=mw ${dtbaddr} 0;" \
>> +" sf probe && sf read ${scradr} 0xC0000 0x10000 && source ${scradr};" \
>> +" fdt addr ${dtbaddr} || cp ${fdtcontroladdr} ${dtbaddr} 4000\0" \
>> +"vxargs=setenv bootargs gem(0,0)host:vxWorks h=${serverip}" \
>> +" e=${ipaddr}:${netmask} g=${gatewayip} u=vxWorksFTP pw=vxWorks\0" \
>> +"vxfdt=fdt addr ${dtbaddr}; fdt resize 0x10000;" \
>> +" fdt set /fpga status ${fpgastatus};" \
>> +" fdt boardsetup\0" \
>> +"startvx=run vxargs && mw 0x1100 0 && run vxfdt &&" \
>> +" bootm ${loadaddr} - ${dtbaddr}\0" \
>> +"b_break=0\0" \
>> +"b_tgts_std=mmc spi usb0 net0 net1\0" \
>> +"b_tgts_rcy=spi usb0 net0 net1\0" \
>> +"b_tgts_pme=usb0 net0 net1 mmc spi\0" \
>> +"b_deftgts=if test ${b_mode} = 12; then setenv b_tgts ${b_tgts_pme};" \
>> +" elif test ${b_mode} = 0; then setenv b_tgts ${b_tgts_rcy};" \
>> +" else setenv b_tgts ${b_tgts_std}; fi\0" \
>> +"b_mmc=run fpga; mmc dev 0; load mmc 0 ${loadaddr} arimg && run startvx\0" \
>> +"b_spi=run fpga; sf read ${loadaddr} 900000 700000 && run startvx\0" \
>> +"b_net0=tftp ${scradr} netscr-brsmarc2-${board_id}.img && source ${scradr}\0" \
>> +"b_net1=tftp ${scradr} netscript.img && source ${scradr}\0" \
>> +"b_usb0=usb start && load usb 0 ${scradr} bootscr.img && source ${scradr}\0" \
>> +"b_default=run b_deftgts; for target in ${b_tgts};"\
>> +" do run b_${target}; if test ${b_break} = 1; then; exit; fi; done\0"
> we are trying to get rid of these variables. Please enable distro boot
> and put all of these to scripts and run them.
No, i don't want some distro defaults ... because we've our own boot 
strategy.
>
>> +
>> +#define CONFIG_SYS_LOAD_ADDR		0xC0000	/*
>> +						 * default load and execution
>> +						 * address for loads / scripts
>> +						 */
>> +/* Support both device trees and ATAGs. */
>> +#define CONFIG_CMDLINE_TAG
>> +#define CONFIG_SETUP_MEMORY_TAGS
>> +#define CONFIG_INITRD_TAG
>> +#define CONFIG_MACH_TYPE		0xFFFFFFFF
>> +
>> +/* Miscellaneous configurable options */
>> +#define CONFIG_CLOCKS
>> +#define CONFIG_SYS_CONSOLE_INFO_QUIET
>> +#define CONFIG_SYS_BOOTM_LEN		(32 * 1024 * 1024)
>> +/* Physical Memory map */
>> +#define CONFIG_SYS_TEXT_BASE		0x4000000
>> +
>> +#define CONFIG_SYS_SDRAM_BASE		0
>> +
>> +#define CONFIG_SYS_MEMTEST_START	CONFIG_SYS_SDRAM_BASE
>> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x1000)
>> +
>> +#define CONFIG_SYS_MALLOC_LEN		0x1400000
>> +#define CONFIG_SYS_INIT_RAM_ADDR	CONFIG_SYS_SDRAM_BASE
>> +#define CONFIG_SYS_INIT_RAM_SIZE	CONFIG_SYS_MALLOC_LEN
>> +#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_INIT_RAM_ADDR + \
>> +					CONFIG_SYS_INIT_RAM_SIZE - \
>> +					GENERATED_GBL_DATA_SIZE)
>> +/* Enable the PL to be downloaded */
>> +#define CONFIG_FPGA_ZYNQPL
> this is definitely in Kconfig already.
ok. i will drop it in V3.
Maybe we also need to adapt the config whitelist.
>
>> +
>> +#define CONFIG_SYS_LDSCRIPT	"arch/arm/mach-zynq/u-boot.lds"
>> +
>> +/* SPL part */
>> +#define CONFIG_SPL_I2C_SUPPORT
>> +
>> +#define CONFIG_SPL_LDSCRIPT	"arch/arm/mach-zynq/u-boot-spl.lds"
>> +
>> +/* Disable dcache for SPL just for sure */
>> +#ifdef CONFIG_SPL_BUILD
>> +# define CONFIG_SYS_DCACHE_OFF
>> +#endif /* CONFIG_SPL_BUILD */
>> +
>> +#ifdef CONFIG_ZYNQ_QSPI
>> +# define CONFIG_SPL_SPI_LOAD
>> +# define CONFIG_SYS_SPI_U_BOOT_OFFS	0x40000
>> +#endif /* CONFIG_ZYNQ_QSPI */
>> +
>> +/* SP location before relocation, must use scratch RAM */
>> +#define CONFIG_SPL_TEXT_BASE		0x0
>> +/* 3 * 64kB blocks of OCM - one is on the top because of bootrom */
>> +#define CONFIG_SPL_MAX_SIZE		0x30000
>> +/* The highest 64k OCM address */
>> +#define OCM_HIGH_ADDR			0xffff0000
>> +/* Just define any reasonable size */
>> +#define CONFIG_SPL_STACK_SIZE		0x2000
>> +/* SPL stack position - and stack goes down */
>> +#define CONFIG_SPL_STACK		(OCM_HIGH_ADDR + CONFIG_SPL_STACK_SIZE)
>> +/* On the top of OCM space */
>> +#define CONFIG_SYS_SPL_MALLOC_START	(CONFIG_SPL_STACK + \
>> +					 GENERATED_GBL_DATA_SIZE)
>> +#define CONFIG_SYS_SPL_MALLOC_SIZE	0x8000
>> +/* BSS setup */
>> +#define CONFIG_SPL_BSS_START_ADDR	0x100000
>> +#define CONFIG_SPL_BSS_MAX_SIZE		0x100000
>> +#define CONFIG_SYS_UBOOT_START		CONFIG_SYS_TEXT_BASE
> There shouldn't be a need to duplicate these setups. Just use what it is
> there already and source common header.
as told already, i will review again if i can use the common header 
without disturbing me ;-)
>
> M
thanks again for your good review and helping me in this.

cheers,
hannes


More information about the U-Boot mailing list