[U-Boot] [PATCH v1 12/18] usb: dwc3: Add dwc3_of_parse() to get quirks information from DT

Marek Vasut marex at denx.de
Fri May 3 09:58:18 UTC 2019


On 5/3/19 11:38 AM, Jean-Jacques Hiblot wrote:
> 
> On 29/04/2019 11:58, Marek Vasut wrote:
>> On 4/5/19 2:55 PM, Jean-Jacques Hiblot wrote:
>>> Add a new function that read quirk and configuration information from
>>> the
>>> DT. The goal is to allow platforms using their own version of DWC3
>>> driver
>>> to migrate to the generic DWC3 driver.
>>> The function is adapted from the linux dwc3 driver.
>> >From which commit in Linux ?
> 
> dwc3_get_properties()has been introduced in commit c5ac6116db35d, and
> then several commits have added properties as needs arose, like
> b5a65c406367 ("usb: dwc3: add P3 in U2 SS inactive quirk")

Would be nice to have it in the commit message, in case someone decides
to update the code in the future.

> JJ
> 
>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>>> ---
>> [...]
>>
>>> diff --git a/drivers/usb/dwc3/dwc3-generic.c
>>> b/drivers/usb/dwc3/dwc3-generic.c
>>> index 3d008496f3..158d726623 100644
>>> --- a/drivers/usb/dwc3/dwc3-generic.c
>>> +++ b/drivers/usb/dwc3/dwc3-generic.c
>>> @@ -48,8 +48,12 @@ static int dwc3_generic_probe(struct udevice *dev,
>>>       struct dwc3_generic_plat *plat = dev_get_platdata(dev);
>>>       struct dwc3 *dwc3 = &priv->dwc3;
>>>   +    dwc3->dev = dev;
>>>       dwc3->maximum_speed = plat->maximum_speed;
>>>       dwc3->dr_mode = plat->dr_mode;
>>> +#if CONFIG_IS_ENABLED(OF_CONTROL)
>>> +    dwc3_of_parse(dwc3);
>>> +#endif
>>>         rc = dwc3_setup_phy(dev, &priv->phys, &priv->num_phys);
>>>       if (rc)
>>> @@ -57,7 +61,7 @@ static int dwc3_generic_probe(struct udevice *dev,
>>>         priv->base = map_physmem(plat->base, DWC3_OTG_REGS_END,
>>> MAP_NOCACHE);
>>>       dwc3->regs = priv->base + DWC3_GLOBALS_REGS_START;
>>> -    dwc3->dev = dev;
>>> +
>>>   
>> Drop the extra newline
>>
>>>       rc =  dwc3_init(dwc3);
>>>       if (rc) {
>>>
>>


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list