[U-Boot] [PATCH 1/1] efi_loader: allowable event types in CreateEventEx()

Alexander Graf agraf at csgraf.de
Sun May 5 07:15:46 UTC 2019


On 04.05.19 10:17, Heinrich Schuchardt wrote:
> CreateEventEx() does allow the following event types:


... not ...


>
> * EVT_SIGNAL_EXIT_BOOT_SERVICES
> * EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>


Did you find this proactively or is it fixing some SCT test case? After 
all, functionally the change should be a no-op, because no payload 
should create those events in the first place :). I would just like to 
see some comment about the reasoning in the commit message.

Either way, this is definitely getting us closer to spec conformance, so 
good to have. Maybe one day (if we grow too much), we can have some 
smarts somewhere that allow us to skip all those sanity checks in small 
builds.

Reviewed-by: Alexander Graf <agraf at csgraf.de>


Alex




More information about the U-Boot mailing list