[U-Boot] [PATCH] simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver

Auer, Lukas lukas.auer at aisec.fraunhofer.de
Mon May 6 11:25:36 UTC 2019


Hello Heiko,

On Mon, 2019-04-29 at 16:11 +0000, Auer, Lukas wrote:
> Hello Heiko,
> 
> On Mon, 2019-04-29 at 11:40 +0200, Heiko Schocher wrote:
> > Hello Simon,
> > 
> > Am 22.04.2019 um 04:38 schrieb sjg at google.com:
> > > On Wed, Apr 10, 2019 at 8:46 PM Lukas Auer
> > > <lukas.auer at aisec.fraunhofer.de> wrote:
> > > > Boards such as qemu-riscv, which receive their device tree at runtime,
> > > > for example from QEMU or firmware, are unable to add the appropriate
> > > > device tree properties to make devices available pre relocation.
> > > > Instead, they must rely on the DM_FLAG_PRE_RELOC flag to be set for the
> > > > required drivers.
> > > > 
> > > > Add the DM_FLAG_PRE_RELOC flag to the simple-bus driver to make devices
> > > > under it with drivers that have set the flag as well available pre
> > > > relocation for these boards.
> > > > 
> > > > Signed-off-by: Lukas Auer <lukas.auer at aisec.fraunhofer.de>
> > > > ---
> > > > 
> > > >   drivers/core/simple-bus.c | 1 +
> > > >   1 file changed, 1 insertion(+)
> > > > 
> > > 
> > > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> > > 
> > > Tested on QEMU RISC-V 'virt' target with 2 cores, M-mode
> > > Tested-by: Bin Meng <bmeng.cn at gmail.com>
> > > 
> > > Applied to u-boot-dm, thanks!
> > 
> > I just tested current mainline U-Boot:
> > 
> > * 6aebc0d11a - (origin/master, origin/HEAD) Revert "fs: btrfs: fix false negatives in ROOT_ITEM 
> > search" (vor 2 Tagen) <Tom Rini>
> > 
> > on a not yet mainlined imx6ull port, and after SPL loaded U-Boot
> > into RAM I see no more output. After git bisect session, this
> > commit was found as the reason for breaking U-Boot.
> > 
> > After reverting this commit, board boots fine again...
> > 
> > Any Idea what could be wrong ?
> > 
> > Thanks!
> > 
> > bye,
> > Heiko
> 
> Can you attach a debugger to the system?
> 
> I can't think of anything apparent that this patch might have
> broken. Is U-Boot perhaps using a different serial console, which was
> not available without this patch?
> 

This issue is fixed with the following patch [1]. The issue was that
the default value of CONFIG_SYS_MALLOC_F_LEN for i.MX was too low,
increasing it fixes the problem.

Thanks,
Lukas

[1]: https://patchwork.ozlabs.org/patch/1094974/


More information about the U-Boot mailing list