[U-Boot] [PATCH v1] ARM: socfpga: stratix10: Enable DMA330 DMA controller

Marek Vasut marex at denx.de
Tue May 7 03:39:12 UTC 2019


On 5/7/19 5:28 AM, Ang, Chee Hong wrote:
> On Fri, 2019-05-03 at 21:31 +0200, Marek Vasut wrote:
>> On 5/3/19 7:56 PM, Ang, Chee Hong wrote:
>>>
>>> On Fri, 2019-05-03 at 19:04 +0200, Marek Vasut wrote:
>>>>
>>>> On 5/3/19 5:53 PM, Ang, Chee Hong wrote:
>>>>>
>>>>>
>>>>> On Fri, 2019-05-03 at 11:55 +0200, Marek Vasut wrote:
>>>>>>
>>>>>>
>>>>>> On 5/3/19 10:18 AM, chee.hong.ang at intel.com wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> From: "Ang, Chee Hong" <chee.hong.ang at intel.com>
>>>>>> Commit message is missing -- why do you need to enable the
>>>>>> DMA330
>>>>>> ?
>>>>>>
>>>>>> Don't you have a reset driver, like A10 and Gen5 ?
>>>>> DMA driver for S10 is still missing in u-boot. I need to enable
>>>>> this
>>>>> for booting Linux which is required by Linux's DMA driver.
>>>>> I will add the reason to enable DMA330 in the commit message.
>>>> Can you also answer my question regarding the reset driver ?
>>> Yes. S10 has a reset driver in drivers/reset/reset-socfpga.c.
>> So why don't you use it ? :-)
> Since our u-boot don't have DMA330 driver, I am going to drop this
> patch and let Linux DMA driver take care of the reset. Thanks.

That sounds like a good idea -- only enable peripherals when they are
really needed.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list